-
Notifications
You must be signed in to change notification settings - Fork 12
pubsub: Add SNS publish API #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ency resolution and fix jena-shaded-guava dependency issues
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
============================================
+ Coverage 83.19% 83.35% +0.15%
Complexity 94 94
============================================
Files 150 151 +1
Lines 8195 8393 +198
Branches 952 993 +41
============================================
+ Hits 6818 6996 +178
- Misses 926 938 +12
- Partials 451 459 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| this.providerId = AwsConstants.PROVIDER_ID; | ||
| } | ||
|
|
||
| public Builder withServiceType(ServiceType serviceType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look ideal, the end user will have to use SQS and SNS ? these are very aws specific.
we should have some cloud agnostic terms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated the builder to infer whether to use SNS or SQS based on the provided topic name (ARN or queue name/URL)
So end users no longer need to explicitly choose AWS specific service types.
Summary
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: