Skip to content

Conversation

@roseyang62
Copy link
Contributor

@roseyang62 roseyang62 commented Dec 18, 2025

Summary

  • Added support for publishing messages to AWS SNS topics

Some conventions to follow

  1. add the module name as a prefix
    • for example: add a prefix: docstore: for document store module, blobstore for Blob Store module
  2. for a test only PR, add test:
  3. for a perf improvement only PR, add perf:
  4. for a refactoring only PR, add "refactor:"

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 89.41176% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.35%. Comparing base (9066147) to head (7f0048f).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...om/salesforce/multicloudj/pubsub/aws/AwsTopic.java 86.95% 8 Missing and 10 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #226      +/-   ##
============================================
+ Coverage     83.19%   83.35%   +0.15%     
  Complexity       94       94              
============================================
  Files           150      151       +1     
  Lines          8195     8393     +198     
  Branches        952      993      +41     
============================================
+ Hits           6818     6996     +178     
- Misses          926      938      +12     
- Partials        451      459       +8     
Flag Coverage Δ
unittests 83.35% <89.41%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

this.providerId = AwsConstants.PROVIDER_ID;
}

public Builder withServiceType(ServiceType serviceType) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look ideal, the end user will have to use SQS and SNS ? these are very aws specific.
we should have some cloud agnostic terms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated the builder to infer whether to use SNS or SQS based on the provided topic name (ARN or queue name/URL)

So end users no longer need to explicitly choose AWS specific service types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants