Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async error catch #368

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

schectms
Copy link

@schectms schectms commented Jun 2, 2020

This PR contains:

-Error catching for async calls in scripts

Describe the problem you have without this PR

-Script hung when async call not fulfilled, for example when a pdf was open when the export script was run. The script will now exit and log the error to the console.

Copy link

@CripterHack CripterHack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An addition needed to catching events to handle errors

@pubkey
Copy link
Collaborator

pubkey commented Feb 15, 2023

Can you make this PR without adding the generated pdf files?
This would make it easier to review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants