Fix the bug when resetting the limit based on the response handler #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sammyjo20 Hi, just checking in on this PR — is there anything I can do to help move it forward? |
|
@Sammyjo20, Follow up on this PR when you have a moment. Could you take a look? |
|
@Sammyjo20 Regarding this PR, do you have any suggestions? This bug blocks our way of handling rate limits using the response handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Response-based limiters (created with
Limit::custom()) were incrementing hit counters during resets, causing inaccurate rate limiting.Fix
Skip hit increment for response-based limiters during reset operations.
@Sammyjo20 Could you please review this fix? This bug prevents us from using the response-based limiter.