Avoid triggering ember.js#19392 with synthetic attr nodes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
force-pushed
the
avoid-template-compilation-warnings
branch
from
a69da39
to
b3aa7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with the version of
@glimmer/syntaxthat landed in Ember 3.25, synthetic attributes added to an element node trigger a warning because theirlocis treated as a real source location at offset 0, and the content there typically won't match the name of the attribute being emitted.Ultimately it would be great to fix that, but given that the fix is unlikely to get backported to all affected Ember versions, we're including a workaround here in the meantime.