New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes deprecated usage of `node.path.orignal` in `htmlbars-plugin` #321

Open

syphe wants to merge 1 commit into salsify:master from syphe:fix-deprecated-usage-of-path-original

syphe commented Sep 3, 2024

The original property on literal nodes is deprecated: https://github.com/glimmerjs/glimmer-vm/blob/10eae7429b702b1e7f5434b91802d5767ff7ad9a/packages/%40glimmer/syntax/lib/v1/legacy-interop.ts#L130

This PR adds a check to see whether the path is one of the literal node paths, and if so does not access the original property


          Update index.js

206e4d3

Author

syphe commented Sep 3, 2024

Could also change the check for literal's to either endsWith 'Literal', or check only for path.node.type === 'PathExpression'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet