Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError for ManagedIdentityCredential when using service principal credentials #49

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

M3GH4NN
Copy link
Collaborator

@M3GH4NN M3GH4NN commented Mar 6, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes: #46

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@M3GH4NN M3GH4NN added the bug Something isn't working label Mar 6, 2024
@M3GH4NN M3GH4NN requested a review from nicholasmhughes March 7, 2024 16:49
src/saltext/azurerm/utils/azurerm.py Outdated Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Outdated Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Outdated Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Show resolved Hide resolved
src/saltext/azurerm/utils/azurerm.py Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 47.87%. Comparing base (49102d0) to head (2b06853).

❗ Current head 2b06853 differs from pull request most recent head 7b96fa6. Consider uploading reports for the commit 7b96fa6 to get more accurate results

Files Patch % Lines
src/saltext/azurerm/utils/azurerm.py 37.50% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   50.04%   47.87%   -2.18%     
==========================================
  Files          19       19              
  Lines        1007     1013       +6     
  Branches       60       61       +1     
==========================================
- Hits          504      485      -19     
- Misses        492      515      +23     
- Partials       11       13       +2     
Flag Coverage Δ
Linux 47.87% <37.50%> (-2.18%) ⬇️
project 64.32% <37.50%> (-7.19%) ⬇️
py310 47.77% <37.50%> (-2.28%) ⬇️
py38 47.72% <37.50%> (-2.28%) ⬇️
py39 47.82% <37.50%> (-2.18%) ⬇️
salt_3005_4 47.82% <37.50%> (-2.18%) ⬇️
salt_3006_4 47.87% <37.50%> (-2.18%) ⬇️
tests 44.53% <ø> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nicholasmhughes nicholasmhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore (blocking): looks good. just need a changelog file

changelog/46.fixed.md Outdated Show resolved Hide resolved
@nicholasmhughes nicholasmhughes changed the title Bug keyvault Fix TypeError for ManagedIdentityCredential when using service principal credentials Mar 15, 2024
@nicholasmhughes nicholasmhughes merged commit c9150b5 into main Mar 15, 2024
7 of 17 checks passed
@nicholasmhughes nicholasmhughes deleted the bug_keyvault branch March 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants