Add shield functionality #9
Conversation
|
Having worked a bit with these changes, I see that some adjustments need to be made before:
|
| @@ -1,12 +1,16 @@ | |||
| include: | |||
| - elasticsearch.pkg | |||
| - elasticsearch.config | |||
| - elasticsearch.shield | |||
There was a problem hiding this comment.
I think shield should be included via a enable_shield (or similar) pillar item as not everyone is going to use shield. Same goes for the watch's on the shield specific files below.
| - template: jinja | ||
| - user: root | ||
| - require: | ||
| - sls: elasticsearch.pkg |
There was a problem hiding this comment.
Could these configs not make use of file.serialize?
There was a problem hiding this comment.
Again, I agree that would probably be preferred, cheers
|
Quick follow up: I have been swamped with other things. I have made some of the mentioned changes in my local running formula, but I do not consider the changes of a sharable quality just yet. Hopefully I can come back with something in December. |
|
Looking forward to reviewing it when it's ready, @simonclausen! |
|
Ok, so almost half a year later I have time to take this up again. Also a lot of great stuff has been done to this repo. So I am closning this and will be starting over, of course taking the input here with me. |
Related to #7 - I needed it for myself so I just went ahead and wrote the state and templates. Depending on which direction this formula should go, this can also be implemented in an add-on formula.
But then again, as I mentioned in #7, I see shield as core functionality. And, no elasticsearch, no shield :)
P.S. because I did a late separate branch, this also includes the suggested change in #6.