Finish etcd test suite [Tech Debt] #61756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKLeb
requested review from
twangboy and
waynew
and removed request for
a team and
twangboy
waynew
reviewed
Mar 4, 2022
|
re-run pr-photon-3-x86_64-py3-pytest |
waynew
previously approved these changes
Mar 7, 2022
There was a problem hiding this comment.
I think this is good - I am not quite positive if we have enough test coverage to make me comfortable (i.e. having some light functional tests) based on some of the things that I've seen in other parts of the codebase, using etcd.
I'll see about putting together some example or something to see if I can reproduce what I'm talking about.
MKLeb
changed the title
MKLeb
changed the title
|
re-run pr-macosx-catalina-x86_64-py3-pytest |
|
re-run pr-ubuntu-2004-arm64-py3-pytest |
Ch3LL
suggested changes
Mar 23, 2022
Ch3LL
approved these changes
Mar 25, 2022
|
re-run all |
waynew
approved these changes
Mar 30, 2022
|
re-run all |
|
re-run pr-centos-7-x86_64-py3-tcp-pytest |
|
re-run pr-centosstream-8-x86_64-py3-pytest |
|
re-run pr-centos-7-x86_64-py3-pycryptodome-pytest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Finishes etcd testing suite in anticipation of soon adopting another etcd client library for APIv3 support. It was decided that unit tests will serve the needed purpose here, since the functional testing is all done in
utils.test_etcd_util. The other pieces simply rely, in some way, on that utility module to actually connect to the etcd service.Also...
Changes logic in
modules.etcd_mod.getto take full advantage ofutils.etcd_util.getwhich now defers toutils.etcd_util.treein the recursive case. Nothing was fixed, just a cleaner implementation.Fixes
returners.etcd_returnbeing profoundly out of tune with its underlying usage ofutils.etcd_util. Removed.valueaccesses fromgetreturns and made use of thetreereturns in the case where recursivegetwas necessary.What issues does this PR fix or reference?
Fixes: All but one piece of #60325
Inidvidual issues: #61033, #61034, #61035, #61036
Note: issue closure dependent on the choice of v3 library.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes