-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plasma-*, sdds-*
: Vertical Tabs added
#1374
Conversation
Theme Builder app deployed! https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1374/ |
⚡ Component performance testingResult: 💀 WASTED Performance tests are broken. |
Можешь пожалуйста описать различия по свойствам между вертикальными и горизонтальными табами? |
cc061ef
to
4f03ed2
Compare
Documentation preview deployed! website:https://plasma.sberdevices.ru/pr/pr-1374/ |
@TitanKuzmich Сорри, пропустил твой комментарий: Не будет bound. Будут отдельно HorizontalTabs, HorizontalTabItem и VerticalTabs, VerticalTabItem. Внутри Tabs.ts для каждого пакета будем экспортировать компонент Tabs, внутри которого (в зависимости от Можно в текущем состоянии ветки посмотреть как это выглядит |
4f03ed2
to
4761972
Compare
6adcede
to
86de3d5
Compare
...sma-new-hope/src/components/Tabs/ui/horizontal/HorizontalTabItem/HorizontalTabItem.styles.ts
Show resolved
Hide resolved
...ges/plasma-new-hope/src/components/Tabs/ui/vertical/VerticalTabItem/variations/_view/base.ts
Show resolved
Hide resolved
packages/plasma-new-hope/src/components/Tabs/ui/vertical/VerticalTabs/VerticalTabs.tsx
Show resolved
Hide resolved
86de3d5
to
4c6e32d
Compare
Tabs
value
для горизонтальных и вертикальных табовWhat/why changed
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: