Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma-new-hope: fix Attach #1481

Merged
merged 2 commits into from
Oct 15, 2024
Merged

plasma-new-hope: fix Attach #1481

merged 2 commits into from
Oct 15, 2024

Conversation

denivladislav
Copy link
Contributor

@denivladislav denivladislav commented Oct 14, 2024 •
edited by Salute-Eva
Loading

Attach

  • исправлен onChange, id и name
  • добавлено свойство onClear
  • в документацию добавлен пример с использованием компонента внутри формы

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1481/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1481/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1481/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1481/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1481/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1481/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1481/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1481/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1481/sdds-finportal-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1481/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1481/ui-storybook/

@denivladislav denivladislav self-assigned this Oct 14, 2024
@denivladislav denivladislav marked this pull request as ready for review October 14, 2024 11:05
TitanKuzmich
TitanKuzmich reviewed Oct 15, 2024
View reviewed changes
website/plasma-b2c-docs/docs/components/Attach.mdx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может стоит вынести эту часть доки в раздел с формами?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Завёл:

#1482

@denivladislav denivladislav added this pull request to the merge queue Oct 15, 2024
Merged via the queue into dev with commit 6fd6dd9 Oct 15, 2024
28 checks passed
@denivladislav denivladislav deleted the PLASMA-3666/fix-attach-onchange branch October 15, 2024 11:11
@Salute-Eva Salute-Eva mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

@vadim-kudr vadim-kudr vadim-kudr approved these changes

Assignees

@denivladislav denivladislav

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denivladislav @vadim-kudr @TitanKuzmich