feat: add leftHelperPlacement prop to TextArea #1579

vadim-kudr · 2024-11-21T01:28:23Z

TextArea

добавлено свойство для выноса левого helper за пределы TextArea

What/why changed

Добавлено свойство leftHelperPlacement?: 'inner' | 'outer'; для выбора расположения вспомогательного текста

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

github-actions · 2024-11-21T01:32:13Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1579/

github-actions · 2024-11-21T01:47:08Z

Documentation preview deployed!

packages/plasma-new-hope/src/components/TextArea/TextArea.types.tsx

packages/sdds-cs/src/components/TextArea/TextArea.stories.tsx

vadim-kudr temporarily deployed to internal November 21, 2024 01:28 — with GitHub Actions Inactive

vadim-kudr force-pushed the PLASMA-3792 branch from b976fd7 to d4e090f Compare November 25, 2024 00:22

vadim-kudr temporarily deployed to internal November 25, 2024 00:22 — with GitHub Actions Inactive

vadim-kudr self-assigned this Nov 26, 2024

vadim-kudr added the plasma-components label Nov 26, 2024

vadim-kudr force-pushed the PLASMA-3792 branch from d4e090f to ad2a361 Compare November 27, 2024 08:43

vadim-kudr temporarily deployed to internal November 27, 2024 08:43 — with GitHub Actions Inactive

vadim-kudr marked this pull request as ready for review November 27, 2024 08:47

vadim-kudr requested review from Yeti-or, neretin-trike, Yakutoc, TitanKuzmich and shuga2704 as code owners November 27, 2024 08:47

neretin-trike reviewed Nov 27, 2024

View reviewed changes

packages/plasma-new-hope/src/components/TextArea/TextArea.types.tsx Outdated Show resolved Hide resolved

github-actions bot requested review from iljs and TitanKuzmich and removed request for Yeti-or, Yakutoc, TitanKuzmich and shuga2704 November 27, 2024 08:52

TitanKuzmich reviewed Nov 27, 2024

View reviewed changes

packages/sdds-cs/src/components/TextArea/TextArea.stories.tsx Outdated Show resolved Hide resolved

TitanKuzmich approved these changes Nov 27, 2024

View reviewed changes

vadim-kudr temporarily deployed to internal November 27, 2024 10:02 — with GitHub Actions Inactive

vadim-kudr force-pushed the PLASMA-3792 branch from 3dd8f7f to 6704223 Compare November 27, 2024 10:14

vadim-kudr temporarily deployed to internal November 27, 2024 10:14 — with GitHub Actions Inactive

vadim-kudr force-pushed the PLASMA-3792 branch from 6704223 to e5aac40 Compare November 27, 2024 12:16

vadim-kudr temporarily deployed to internal November 27, 2024 12:17 — with GitHub Actions Inactive

feat: add helperPlacement prop to TextArea

874cc34

vadim-kudr force-pushed the PLASMA-3792 branch from e5aac40 to 874cc34 Compare November 27, 2024 14:11

vadim-kudr temporarily deployed to internal November 27, 2024 14:11 — with GitHub Actions Inactive

vadim-kudr changed the title ~~feat: add helperPlacement prop to TextArea~~ feat: add leftHelperPlacement prop to TextArea Nov 27, 2024

neretin-trike approved these changes Nov 27, 2024

View reviewed changes

Yakutoc removed the request for review from iljs November 27, 2024 14:36

TitanKuzmich added this pull request to the merge queue Nov 27, 2024

Merged via the queue into dev with commit eb15b67 Nov 27, 2024
32 checks passed

TitanKuzmich deleted the PLASMA-3792 branch November 27, 2024 15:17

Salute-Eva mentioned this pull request Nov 27, 2024

Release by 27.11.2024 #1597

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add leftHelperPlacement prop to TextArea #1579

feat: add leftHelperPlacement prop to TextArea #1579

vadim-kudr commented Nov 21, 2024 •

edited by Salute-Eva

Loading

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024 •

edited

Loading

feat: add leftHelperPlacement prop to TextArea #1579

feat: add leftHelperPlacement prop to TextArea #1579

Conversation

vadim-kudr commented Nov 21, 2024 • edited by Salute-Eva Loading

TextArea

What/why changed

github-actions bot commented Nov 21, 2024

github-actions bot commented Nov 21, 2024 • edited Loading

vadim-kudr commented Nov 21, 2024 •

edited by Salute-Eva

Loading

github-actions bot commented Nov 21, 2024 •

edited

Loading