Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-3859: Update TextArea design #1592

Merged
merged 3 commits into from
Nov 28, 2024
Merged

PLASMA-3859: Update TextArea design #1592

merged 3 commits into from
Nov 28, 2024

Conversation

neretin-trike
Copy link
Collaborator

@neretin-trike neretin-trike commented Nov 25, 2024 •
edited by Salute-Eva
Loading

TextArea

  • Исправлено отображение рамки с помощью css свойства box-shadow
  • Добавлена поддержка boxShadow
  • Добавлен размер XL

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@neretin-trike neretin-trike self-assigned this Nov 25, 2024
@neretin-trike neretin-trike marked this pull request as draft November 25, 2024 17:58
@github-actions GitHub Actions
Copy link
Contributor

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1592/

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1592/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1592/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1592/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1592/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1592/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1592/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1592/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1592/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1592/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1592/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1592/ui-storybook/

@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from 974a36a to 78097e5 Compare November 26, 2024 11:20
@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from 78097e5 to 767f007 Compare November 26, 2024 18:37
@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from 767f007 to 5a99fb7 Compare November 26, 2024 18:57
@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from 5a99fb7 to 1220ad8 Compare November 27, 2024 08:26
@github-actions github-actions bot requested review from shuga2704 and TitanKuzmich and removed request for Yeti-or, Yakutoc, TitanKuzmich and shuga2704 November 27, 2024 09:20
@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from 1220ad8 to 0b32c5b Compare November 27, 2024 09:29
shuga2704
shuga2704 reviewed Nov 27, 2024
View reviewed changes
packages/plasma-new-hope/src/components/TextArea/TextArea.styles.ts
@@ -314,7 +314,9 @@ export const StyledIndicator = styled.div`
inset: var(${tokens.indicatorLabelPlacementOuterRight});

&.${classes.hasHint} {
right: calc(-1 * var(${tokens.indicatorSizeOuter}));
right: calc(
-1 * var(${tokens.indicatorSizeOuter}) + var(${tokens.indicatorLabelPlacementHintOuterRight}, 0px)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

но но какие px Артем, ай накосячил)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут я умышленно пиксели поставил на самом деле, просто 0 не будет работать, а rem как будто бы ненужны здесь

shuga2704
shuga2704 reviewed Nov 27, 2024
View reviewed changes
packages/plasma-new-hope/src/components/TextArea/variations/_view/base.ts
transition: box-shadow 0.1s ease-in-out;
border-radius: var(${tokens.borderRadius});
border: var(${tokens.borderSize}) solid var(${tokens.borderColor});
box-shadow: inset 0 0 0 var(${tokens.borderSize}, 1px) var(${tokens.borderColor}), var(${tokens.boxShadow}, inset 0 0 0 0 transparent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уфф

@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from 0b32c5b to ea4ae3b Compare November 27, 2024 11:40
@neretin-trike neretin-trike force-pushed the neretinaa/sdds-insol-update-textarea-design branch from ea4ae3b to c62ab3b Compare November 28, 2024 10:17
@neretin-trike neretin-trike added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit dedea02 Nov 28, 2024
29 checks passed
@neretin-trike neretin-trike deleted the neretinaa/sdds-insol-update-textarea-design branch November 28, 2024 11:06
@Yakutoc Yakutoc changed the title feat(sdds-insol): Update TextArea design PLASMA-3859: Update TextArea design Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irinkv Irinkv Irinkv approved these changes

@shuga2704 shuga2704 shuga2704 approved these changes

@TitanKuzmich TitanKuzmich TitanKuzmich approved these changes

Assignees

@neretin-trike neretin-trike

Labels
plasma-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neretin-trike @TitanKuzmich @shuga2704 @Irinkv