Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLASMA-4081: Autocomplete RequiredProps types #1608

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

PLASMA-4081: Autocomplete RequiredProps types #1608

wants to merge 1 commit into from
+57 −66

Conversation

vadim-kudr
Copy link
Contributor

@vadim-kudr vadim-kudr commented Dec 2, 2024 •
edited by Salute-Eva
Loading

Autocomplete

Возвращены RequiredProps типы для Autocomplete

What/why changed (Это обязательный заголовок)

Возвращены RequiredProps типы для Autocomplete

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
npm install @salutejs/[email protected]
# or 
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]
yarn add @salutejs/[email protected]

@vadim-kudr vadim-kudr added the bugs Something isn't working label Dec 2, 2024
@vadim-kudr vadim-kudr self-assigned this Dec 2, 2024
@vadim-kudr vadim-kudr marked this pull request as ready for review December 2, 2024 07:09
@github-actions github-actions bot requested review from denivladislav and iljs and removed request for Yeti-or, Yakutoc, neretin-trike, TitanKuzmich and shuga2704 December 2, 2024 07:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-1608/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Documentation preview deployed!

website:https://plasma.sberdevices.ru/pr/pr-1608/
asdk storybook: https://plasma.sberdevices.ru/pr/pr-1608/asdk-storybook/
b2c storybook: https://plasma.sberdevices.ru/pr/pr-1608/b2c-storybook/
new-hope storybook: https://plasma.sberdevices.ru/pr/pr-1608/new-hope-storybook/
web storybook: https://plasma.sberdevices.ru/pr/pr-1608/web-storybook/
sdds-cs storybook: https://plasma.sberdevices.ru/pr/pr-1608/sdds-cs-storybook/
sdds-dfa storybook: https://plasma.sberdevices.ru/pr/pr-1608/sdds-dfa-storybook/
sdds-finportal storybook: https://plasma.sberdevices.ru/pr/pr-1608/sdds-finportal-storybook/
sdds-insol storybook: https://plasma.sberdevices.ru/pr/pr-1608/sdds-insol-storybook/
sdds-serv storybook: https://plasma.sberdevices.ru/pr/pr-1608/sdds-serv-storybook/
ui storybook: https://plasma.sberdevices.ru/pr/pr-1608/ui-storybook/

denivladislav
denivladislav reviewed Dec 2, 2024
View reviewed changes
packages/plasma-b2c/api/plasma-b2c.api.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вопрос по оформлению прки – по новым правилам оформления у этого пр не должно быть номера задачи?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У этой есть задача в Jira - PLASMA-4081

@Yakutoc Yakutoc changed the title fix: Autocomplete RequiredProps types PLASMA-4081: Autocomplete RequiredProps types Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denivladislav denivladislav denivladislav approved these changes

@Yakutoc Yakutoc Yakutoc left review comments

@shuga2704 shuga2704 shuga2704 approved these changes

@iljs iljs Awaiting requested review from iljs

Assignees

@vadim-kudr vadim-kudr

Labels
bugs Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vadim-kudr @Yakutoc @shuga2704 @denivladislav