Minor code optimization

salvo-rs · Jul 29, 2024 · 8aaa432 · 8aaa432
1 parent 286a34e
commit 8aaa432
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/crates/core/src/routing/filters/path.rs b/crates/core/src/routing/filters/path.rs
@@ -759,8 +759,8 @@ impl PathParser {
             let mut scaned = self.scan_wisps()?;
             if scaned.len() > 1 {
                 wisps.push(CombWisp(scaned).into());
-            } else if !scaned.is_empty() {
-                wisps.push(scaned.pop().expect("scan parts is empty"));
+            } else if let Some(wisp)  = scaned.pop() {
+                wisps.push(wisp);
             } else {
                 return Err("scan parts is empty".to_owned());
             }

diff --git a/crates/oapi/src/lib.rs b/crates/oapi/src/lib.rs
@@ -416,9 +416,11 @@ impl ToSchema for serde_json::Map<String, serde_json::Value> {
 ///      static METADATA: Metadata = Metadata::new("");
 ///      &METADATA
 ///    }
+///    #[allow(refining_impl_trait)]
 ///    async fn extract(req: &'ex mut Request) -> Result<Self, salvo_core::http::ParseError> {
 ///        salvo_core::serde::from_request(req, Self::metadata()).await
 ///    }
+///    #[allow(refining_impl_trait)]
 ///    async fn extract_with_arg(req: &'ex mut Request, _arg: &str) -> Result<Self, salvo_core::http::ParseError> {
 ///        Self::extract(req).await
 ///    }