Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meilisearch): add basic set of rules #425

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat(meilisearch): add basic set of rules #425

merged 4 commits into from
Jul 2, 2024

Conversation

nohant
Copy link
Contributor

@nohant nohant commented Jun 28, 2024

this should add a basic set of rules for meilisearch, i would like to expand this in the future when we will add more in our production cluster.

Documentation for metrics is here: https://www.meilisearch.com/docs/learn/experimental/metrics
im not supergood at this but i want to give something back to the community! :D

_data/rules.yml Outdated
rules:
- name: Meilisearch index is empty
description: Meilisearch instance is down
query: 'meilisearch_index_docs_count{index="$Index"} == 0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think {index="$Index"} is not expected here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the filter in the dashboard for grafana we use is configured this way: meilisearch_index_docs_count{index="$Index"} , do you think there is a better way to put it?

the last action failed due to the single = before the 0.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that the $Index is a variable injected by Grafana.

If you want to match every indices, I suppose the meilisearch_index_docs_count == 0 would work.

(I cannot test)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uuuuh, youre right @samber

We se that variable and use it in explore, but without the label will it be more general and clean!
thanks, i wanted to be more precise but that is good enough for a standard alert. :3.

@samber
Copy link
Owner

samber commented Jul 2, 2024

let's merge ;)

@samber samber merged commit 9557d4b into samber:master Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants