[pre-commit.ci] pre-commit autoupdate #19
Conversation
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
=======================================
Coverage 35.49% 35.49%
=======================================
Files 5 5
Lines 386 386
Branches 48 48
=======================================
Hits 137 137
Misses 249 249
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
db976a5
to
1134fbe
Compare
|
@samdoran could you click "rebase" on the PR? I hope that with the updates to |
|
I don't think a rebase is necessary since the checkout action usually does a speculative merge when testing. |
|
A CI restart, then? It probably ran before those changes. |
|
Though, you'd have to restart both GHA and pre-commit.ci which requires a specially crafted comment. |
|
The latter can be achieved by posting the following comment: |
|
pre-commit.ci run |
|
Not sure why it's not pulling in changes as expected. I'll just rebase this branch. |
samdoran
force-pushed
the
pre-commit-ci-update-config
branch
from
346f798
to
3959a43
Compare
|
Looks like the test failures are the same. I'll investigate. |
|
Looks like a few more import and compile ignores are needed due to the trailing comma change. |
|
Those trailing commas result in a lot of tests needing to be skipped. I wonder if we could just change the method signature instead. I have a feeling once I get the import and compile tests passing, the tests themselves will fail when they try to run. |
GitHub doesn't always update the ephemeral merge commit that many services use. It usually updates it when the PR is updated, not something external. Only automations that do this manually would work around this. |
Oh, right! I forgot that older Pythons didn't allow trailing commas after |
updates: - [github.com/asottile/add-trailing-comma.git: v2.4.0 → v3.0.0](https://github.com/asottile/add-trailing-comma.git/compare/v2.4.0...v3.0.0) - [github.com/Lucas-C/pre-commit-hooks.git: v1.3.1 → v1.5.1](https://github.com/Lucas-C/pre-commit-hooks.git/compare/v1.3.1...v1.5.1) - [github.com/adrienverge/yamllint.git: v1.28.0 → v1.32.0](https://github.com/adrienverge/yamllint.git/compare/v1.28.0...v1.32.0) - [github.com/PyCQA/flake8.git: 5.0.4 → 6.0.0](https://github.com/PyCQA/flake8.git/compare/5.0.4...6.0.0) - [github.com/PyCQA/flake8.git: 4.0.1 → 6.0.0](https://github.com/PyCQA/flake8.git/compare/4.0.1...6.0.0) - [github.com/PyCQA/pylint.git: v2.15.9 → v3.0.0a6](https://github.com/PyCQA/pylint.git/compare/v2.15.9...v3.0.0a6)
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
samdoran
force-pushed
the
pre-commit-ci-update-config
branch
from
96cfbd7
to
5839060
Compare
v3.0.0 only supports Python >=3.6.
samdoran
force-pushed
the
pre-commit-ci-update-config
branch
from
4272151
to
2844e7a
Compare
updates: