Add new versions for CI (#223)

* Add new versions for CI * Add ruby 3.1 for dev env --------- Co-authored-by: zogoo <[email protected]>
saml-idp · Oct 24, 2024 · 101925b · 101925b
1 parent 62ca537
commit 101925b
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,26 +11,38 @@ jobs:
       fail-fast: false
       matrix:
         ruby: ['2.5', '2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
-        gemfile: [rails_5.2.gemfile, rails_6.1.gemfile, rails_7.0.gemfile, rails_7.1.gemfile, rails_dev.gemfile]
+        gemfile: [rails_5.2.gemfile, rails_6.1.gemfile, rails_7.0.gemfile, rails_7.1.gemfile, rails_7.2.gemfile, rails_dev.gemfile]
         exclude:
+          # Ruby 3.2 is min version for Rails 8
+          - ruby: '2.5'
+            gemfile: rails_dev.gemfile
+          - ruby: '2.6'
+            gemfile: rails_dev.gemfile
+          - ruby: '2.7'
+            gemfile: rails_dev.gemfile
+          - ruby: '3.0'
+            gemfile: rails_dev.gemfile
+          - ruby: '3.1'
+            gemfile: rails_dev.gemfile
           - ruby: '2.5'
             gemfile: rails_7.0.gemfile
           - ruby: '2.5'
             gemfile: rails_7.1.gemfile
-          - ruby: '2.5'
-            gemfile: rails_dev.gemfile
           - ruby: '2.6'
             gemfile: rails_7.0.gemfile
           - ruby: '2.6'
             gemfile: rails_7.1.gemfile
+          # Ruby 3.1 is min version for Rails 7.2
+          - ruby: '2.5'
+            gemfile: rails_7.2.gemfile
           - ruby: '2.6'
-            gemfile: rails_dev.gemfile
+            gemfile: rails_7.2.gemfile
           - ruby: '2.7'
-            gemfile: rails_dev.gemfile
+            gemfile: rails_7.2.gemfile
           - ruby: '3.0'
-            gemfile: rails_5.2.gemfile
+            gemfile: rails_7.2.gemfile
           - ruby: '3.0'
-            gemfile: rails_dev.gemfile
+            gemfile: rails_5.2.gemfile
           - ruby: '3.1'
             gemfile: rails_5.2.gemfile
           - ruby: '3.2'

diff --git a/.ruby-version b/.ruby-version
@@ -1 +1 @@
-3.1.2
+3.3.5
diff --git a/gemfiles/rails_7.2.gemfile b/gemfiles/rails_7.2.gemfile
@@ -0,0 +1,8 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 7.2.0"
+gem 'activeresource', '~> 6.1', '>= 6.1.3'
+
+gemspec path: "../"
diff --git a/saml_idp.gemspec b/saml_idp.gemspec
@@ -50,9 +50,8 @@ Gem::Specification.new do |s|
   s.add_dependency('rexml')
   s.add_dependency('xmlenc', '>= 0.7.1')
 
-  s.add_development_dependency('activeresource', '>= 5.1')
+  s.add_development_dependency('activeresource', '~> 6.1')
   s.add_development_dependency('appraisal')
-  s.add_development_dependency('byebug')
   s.add_development_dependency('capybara', '>= 2.16')
   s.add_development_dependency('rails', '>= 5.2')
   s.add_development_dependency('rake')