Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to switch IdP configurations such as x509cert, secret key and password on the fly #186

Closed
wants to merge 2 commits into from

Conversation

hamaron
Copy link
Contributor

@hamaron hamaron commented Sep 27, 2022

I've had this feature in my fork and used it in Production for years, so I wanted to give it back to the community.

Just as #88, we want to change the IdP configuration such as x509cert, secret key, and password on the fly if the IDP is multitenancy, depending on who the customer is.

You can change the configuration when returning a SAML response like so:

def create
        @saml_response = encode_response(current_user, {
          x509_certificate: "=== Valid Certificate ===",
          secret_key: "Valid Secret Key"
        })
        render template: "saml_idp/idp/saml_post", layout: false
end

The following configuration can be different for each principal:
- X509 Certificate
- Secret Key
- Password
@Zogoo Zogoo added this to the Simplify gem for SAML milestone Jan 4, 2024
@Zogoo Zogoo requested review from jphenow and Zogoo January 5, 2024 00:05
@Zogoo Zogoo self-assigned this Jan 7, 2024
@Zogoo
Copy link
Collaborator

Zogoo commented Jan 7, 2024

@hamaron thanks for your contribution, The code looks good to me.
can you resolve the conflict in your branch?

@Zogoo
Copy link
Collaborator

Zogoo commented Oct 24, 2024

This pull request has been recreated as #209. We will consider that pull request as the latest version since this one is outdated.

@Zogoo Zogoo closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants