fix: threaded_stream #1463
Merged
fix: threaded_stream #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pcriadoperez
commented
Oct 29, 2024
•
pcriadoperez
commented
- Add tests for threaded stream
- Add support for async callback
- improve closing
pcriadoperez
commented
Oct 30, 2024
carlosmiei
reviewed
Oct 30, 2024
|
hum @pcriadoperez this test is failing consistently |
…into test-thread-stream
pcriadoperez
changed the title
|
@pcriadoperez I'm assuming this PR does not apply anymore, but please let me know if otherwise |
…into test-thread-stream
added 3 commits
December 22, 2024 11:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.