Update Endpoints.md, add futures_taker_longshort_ratio and update tests #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ngoclam9415, Thanks for your contribution. We will review and merge it shortly |
|
I forgot to add params to the new test cases which leads to the failed run |
…eters for some APIs
|
Hi @carlosmiei, can you approve the workflow to rerun the test 1 more time |
|
@ngoclam9415 of course :) done |
|
Hi @carlosmiei, seems like there's no sandbox environment to test those APIs. I just updated tests to ignore those APIs. Can you help me rerun the workflow and maybe cancel the current one to save time. |
|
@ngoclam9415 no. problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some APIs are implemented but their statuses are not updated in Endpoints.md. It may be intended to be like that, so correct me if I'm wrong.
I also add
client.futures_taker_longshort_ratiousing takerlongshortRatio endpoint from finance.Finally, I update the tests for all of the above APIs