Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Plyr sizing in a better way #2022

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shravan2x
Copy link
Contributor

Link to related issue (if applicable)

Should fix the issue in a way that both #1997 and #1651 work.

Summary of proposed changes

Checklist

  • Use develop as the base branch
  • Exclude the gulp build (/dist changes) from the PR
  • Test on supported browsers

@@ -13,6 +13,7 @@
font-variant-numeric: tabular-nums; // Force monosace-esque number widths
font-weight: $plyr-font-weight-regular;
line-height: $plyr-line-height;
max-height: 100%
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi you forgot semicolon here

@kgnfth
Copy link

kgnfth commented Nov 17, 2020

its still the same

image

image

@@ -13,6 +13,7 @@
font-variant-numeric: tabular-nums; // Force monosace-esque number widths
font-weight: $plyr-font-weight-regular;
line-height: $plyr-line-height;
max-height: 100%
Copy link

@kgnfth kgnfth Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing max-height to height will fix this
image

to this
image

@dalexhd
Copy link

dalexhd commented Nov 19, 2020

In my case, 3.6.3 version was a bit destructive...

Here is a basic explanation:

gyazo

@shravan2x
Copy link
Contributor Author

Yeah I think we might need to add a new option. I'm still working on this, expect to get somewhere by the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants