Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please adopt to new faust releases #7

Open
magnetophon opened this issue Oct 30, 2016 · 22 comments
Open

please adopt to new faust releases #7

magnetophon opened this issue Oct 30, 2016 · 22 comments

Comments

@magnetophon
Copy link

When building with faust 0.9.90 or 2.0.a51 there are a few build errors.

faust has moved the location of dsp.h, which can be fixed with:

    sed -i include/foo-yc20.h -e 's|faust/audio/dsp.h|faust/dsp/dsp.h|'
    sed -i gen/*.cpp -e 's|faust/audio/dsp.h|faust/dsp/dsp.h|'

Then I get the following error, which I don't know how to fix:

building
make flags: SHELL=/nix/store/28wl3f34vfjpw0y5809bgr6382wqdscf-bash-4.3-p48/bin/bash PREFIX=$(out)   
g++ src/foo-yc20.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall  -c -o src/foo-yc20.o
g++ src/configuration.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall  -c -o src/configuration.o
g++ src/yc20-jack.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall `pkg-config --cflags jack` -c -o src/yc20-jack.o
g++ src/main-gui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall `pkg-config --cflags gtk+-2.0` `pkg-config --cflags jack` -c -o src/main-gui.o
g++ src/foo-yc20-ui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall `pkg-config --cflags gtk+-2.0` `pkg-config --cflags jack` -c -o src/foo-yc20-ui.o
g++ src/yc20-base-ui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall `pkg-config --cflags cairo` -c -o src/yc20-base-ui.o
src/yc20-base-ui.cpp: In destructor 'virtual YC20BaseUI::~YC20BaseUI()':
src/yc20-base-ui.cpp:518:24: warning: deleting object of abstract class type 'Wdgt::Draggable' which has non-virtual destructor will cause undefined behaviour [-Wdelete-non-virtual-dtor]
                 delete obj;
                        ^
g++ src/graphics.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall  -c -o src/graphics.o
g++ src/yc20-precalc.c -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall  -c -o src/yc20-precalc.o
g++ src/faust-dsp-standalone.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/2dkjnb7q9qms2fw77wlzz2yin2pq497h-foo-yc20-git-2015-05-21 -Wall -c -o src/faust-dsp-standalone.o
In file included from src/faust-dsp-standalone.cpp:43:0:
src/../gen/yc20-dsp-standalone.cpp:668:14: error: 'static void mydsp::metadata(Meta*)' cannot be declared
  static void metadata(Meta* m)  { 
              ^
In file included from src/../gen/yc20-dsp-standalone.cpp:35:0,
                 from src/faust-dsp-standalone.cpp:43:
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:121:22: error:   since 'virtual void dsp::metadata(Meta*)' declared in base class
         virtual void metadata(Meta* m) = 0;
                      ^
In file included from src/faust-dsp-standalone.cpp:43:0:
src/../gen/yc20-dsp-standalone.cpp: In member function 'virtual void mydsp::instanceInit(int)':
src/../gen/yc20-dsp-standalone.cpp:690:3: error: 'fSamplingFreq' was not declared in this scope
   fSamplingFreq = samplingFreq;
   ^
src/faust-dsp-standalone.cpp: In function 'dsp* createDSP()':
src/faust-dsp-standalone.cpp:47:25: error: invalid new-expression of abstract class type 'mydsp'
  mydsp *ret = new mydsp();
                         ^
In file included from src/faust-dsp-standalone.cpp:43:0:
src/../gen/yc20-dsp-standalone.cpp:69:7: note:   because the following virtual functions are pure within 'mydsp':
 class mydsp : public dsp {
       ^
In file included from src/../gen/yc20-dsp-standalone.cpp:35:0,
                 from src/faust-dsp-standalone.cpp:43:
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:81:21: note:  virtual int dsp::getSampleRate()
         virtual int getSampleRate() = 0;
                     ^
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:101:22: note:     virtual void dsp::instanceConstants(int)
         virtual void instanceConstants(int samplingRate) = 0;
                      ^
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:104:22: note:     virtual void dsp::instanceResetUserInterface()
         virtual void instanceResetUserInterface() = 0;
                      ^
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:107:22: note:     virtual void dsp::instanceClear()
         virtual void instanceClear() = 0;
                      ^
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:114:22: note:     virtual dsp* dsp::clone()
         virtual dsp* clone() = 0;
                      ^
/nix/store/vgfmf50h1lssf4svg8z99hpslq860y7y-faust-2.0.a51/include/faust/dsp/dsp.h:121:22: note:     virtual void dsp::metadata(Meta*)
         virtual void metadata(Meta* m) = 0;
                      ^
make: *** [Makefile:37: src/faust-dsp-standalone.o] Error 1

It would also be great to adapt it to the new faust libraries.
I made a crude script that helps with that: https://github.com/magnetophon/faustCompressors/blob/master/newlib.sh

Thanks.

@magnetophon
Copy link
Author

I tried to build the latest commit, but I still run into the moved dsp.h file.
When I fix that by running the above sed commands, I get:

g++ -std=c++11 src/foo-yc20.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/39v4fl0ygpwm77j372ywx6qlj7ffgvnb-foo-yc20-git-2018-01-17 -Wall  -c -o src/foo-yc20.o
g++ -std=c++11 src/configuration.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/39v4fl0ygpwm77j372ywx6qlj7ffgvnb-foo-yc20-git-2018-01-17 -Wall  -c -o src/configuration.o
g++ -std=c++11 src/yc20-jack.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/39v4fl0ygpwm77j372ywx6qlj7ffgvnb-foo-yc20-git-2018-01-17 -Wall `pkg-config --cflags jack` -c -o src/yc20-jack.o
g++ -std=c++11 src/main-gui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/39v4fl0ygpwm77j372ywx6qlj7ffgvnb-foo-yc20-git-2018-01-17 -Wall `pkg-config --cflags gtk+-2.0` `pkg-config --cflags jack` -c -o src/main-gui.o
src/main-gui.cpp: In function 'int main(int, char**)':
src/main-gui.cpp:85:11: error: cannot declare variable 'processor' to be of abstract type 'YC20Jack'
  YC20Jack processor;
           ^~~~~~~~~
In file included from src/main-gui.cpp:31:0:
include/yc20-jack.h:42:7: note:   because the following virtual functions are pure within 'YC20Jack':
 class YC20Jack : public YC20Processor
       ^~~~~~~~
In file included from include/foo-yc20.h:37:0,
                 from include/yc20-jack.h:34,
                 from src/main-gui.cpp:31:
/nix/store/s4mkv8izh3bjrd8amf2nag6bij1h39dk-faust-2.5.23/include/faust/gui/UI.h:71:22: note:    virtual void UI::addSoundfile(const char*, const char*, Soundfile**)
         virtual void addSoundfile(const char* label, const char* filename, Soundfile** sf_zone) = 0;
                      ^~~~~~~~~~~~
make: *** [Makefile:39: src/main-gui.o] Error 1

cc @sampov2 @jpcima @trebmuh

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

I have not done any work to enable faust2 compatibility.
In order to compile you need faust headers of the 0.9.x branch. The adaptation is not as trivial as changing an included file.
I did not look into the problem any further, so I do not know how much effort it takes to port. If there is an effort to do faust2, it may be worthwhile to substitute yc20's plugin wrappers with faust architecture files.

@magnetophon
Copy link
Author

I tried again using faust 0.9.90.
I got:

build flags: SHELL=/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash PREFIX=\$\(out\)
g++ -std=c++11 src/foo-yc20.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall  -c -o src/foo-yc20.o
g++ -std=c++11 src/configuration.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall  -c -o src/configuration.o
g++ -std=c++11 src/yc20-jack.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall `pkg-config --cflags jack` -c -o src/yc20-jack.o
g++ -std=c++11 src/main-gui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall `pkg-config --cflags gtk+-2.0` `pkg-config --cflags jack` -c -o src/main-gui.o
g++ -std=c++11 src/foo-yc20-ui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall `pkg-config --cflags gtk+-2.0` `pkg-config --cflags jack` -c -o src/foo-yc20-ui.o
g++ -std=c++11 src/yc20-base-ui.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall `pkg-config --cflags cairo` -c -o src/yc20-base-ui.o
g++ -std=c++11 src/graphics.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall  -c -o src/graphics.o
g++ -std=c++11 src/yc20-precalc.c -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall  -c -o src/yc20-precalc.o
g++ -std=c++11 src/faust-dsp-standalone.cpp -O3 -mtune=native -march=native -mfpmath=sse -ffast-math -ftree-vectorize -fPIC -DVERSION= -Isrc/ -Iinclude/ -DPREFIX=/nix/store/4r8i5mgwcmbisipjjniaji9k973qm1aa-foo-yc20-git-2018-01-17 -Wall -c -o src/faust-dsp-standalone.o
In file included from src/faust-dsp-standalone.cpp:46:0:
src/../gen/yc20-dsp-standalone.cpp:626:14: error: 'static void mydsp::metadata(Meta*)' cannot be declared
  static void metadata(Meta* m)  {
              ^~~~~~~~
In file included from src/faust-dsp-standalone.cpp:44:0:
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:119:22: error:   since 'virtual void dsp::metadata(Meta*)' declared in base class
         virtual void metadata(Meta* m) = 0;
                      ^~~~~~~~
In file included from src/faust-dsp-standalone.cpp:46:0:
src/../gen/yc20-dsp-standalone.cpp: In member function 'virtual void mydsp::instanceInit(int)':
src/../gen/yc20-dsp-standalone.cpp:648:3: error: 'fSamplingFreq' was not declared in this scope
   fSamplingFreq = samplingFreq;
   ^~~~~~~~~~~~~
src/../gen/yc20-dsp-standalone.cpp:648:3: note: suggested alternative: 'samplingFreq'
   fSamplingFreq = samplingFreq;
   ^~~~~~~~~~~~~
   samplingFreq
src/faust-dsp-standalone.cpp: In function 'dsp* createDSP()':
src/faust-dsp-standalone.cpp:59:28: error: invalid new-expression of abstract class type 'mydsp_ex'
  mydsp *ret = new mydsp_ex();
                            ^
src/faust-dsp-standalone.cpp:48:7: note:   because the following virtual functions are pure within 'mydsp_ex':
 class mydsp_ex : public mydsp
       ^~~~~~~~
In file included from src/faust-dsp-standalone.cpp:44:0:
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:79:21: note:   virtual int dsp::getSampleRate()
         virtual int getSampleRate() = 0;
                     ^~~~~~~~~~~~~
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:99:22: note:   virtual void dsp::instanceConstants(int)
         virtual void instanceConstants(int samplingRate) = 0;
                      ^~~~~~~~~~~~~~~~~
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:102:22: note:  virtual void dsp::instanceResetUserInterface()
         virtual void instanceResetUserInterface() = 0;
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:105:22: note:  virtual void dsp::instanceClear()
         virtual void instanceClear() = 0;
                      ^~~~~~~~~~~~~
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:112:22: note:  virtual dsp* dsp::clone()
         virtual dsp* clone() = 0;
                      ^~~~~
/nix/store/0ypwrbvr44ksviwkw1kqdi2936nr82c8-faust-0.9.90/include/faust/dsp/dsp.h:119:22: note:  virtual void dsp::metadata(Meta*)
         virtual void metadata(Meta* m) = 0;
                      ^~~~~~~~
make: *** [Makefile:39: src/faust-dsp-standalone.o] Error 1

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

Looking at faust outputs in gen/ those are generated by 0.9.73.
What about make generate-source to regenerate faust outputs for your version? does this fix anything?
If not, try this faust1 branch I just pushed. It includes 0.9.73 headers. This builds for me.

@magnetophon
Copy link
Author

magnetophon commented Mar 24, 2018

make generate-source gives me:

build flags: SHELL=/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash PREFIX=\$\(out\) generate-source
faust faust/standalone.dsp > gen/yc20-dsp-standalone.cpp
math.lib:507: ERROR: redefinition of symbols are not allowed : BoxIdent[frac] is already defined in file "math.lib" line 507
math.lib:508: ERROR: redefinition of symbols are not allowed : BoxIdent[decimal] is already defined in file "math.lib" line 508
math.lib:560: WARNING: equivalent re-definitions of BoxIdent[chebychev]
math.lib:582: WARNING: equivalent re-definitions of BoxIdent[chebychevpoly]
Total of 2 errors during the compilation of  faust/standalone.dsp;
make: *** [Makefile:171: generate-source] Error 1

The faust1 branch builds and runs, both the standalone and the lv2, thanks!

Should I base the package for my distro on that branch?

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

I guess the best packaging strategy for now is to include faust 0.9.73 in your build process like my branch does.
I don't promise anything but I will give a shot at upgrading the code for faust2. This would surely make the future maintenance much easier.

jpcima added a commit to jpcima/foo-yc20 that referenced this issue Mar 24, 2018
@magnetophon
Copy link
Author

magnetophon commented Mar 24, 2018

I guess the best packaging strategy for now is to include faust 0.9.73 in your build process like my branch does.

Not sure what you mean by that.
Wil you leave the faust1 branch here, or should I recreate one in my package by downloading the 0.9.73 sources?
Or something else entirely?

I don't promise anything but I will give a shot at upgrading the code for faust2. This would surely make the future maintenance much easier.

That would be great, thanks.
Another reminder: I made a crude script to make the proces easier.

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

Feel free to use this branch if you like, I will not to change it or move it away. I'm just not member of the project, only a modest contributor.

I think I've managed to add faust2 support (branch), and it seemed surprisingly easy. (version 2.5.23.)
However I have to trouble to compile it optimized and test it because of the old low spec computer I'm currently on. You may want to try it.

@magnetophon
Copy link
Author

magnetophon commented Mar 24, 2018

That builds and runs, using faust 2.5.23, thanks!

I can not change parameters in the standalone version, but I can in the LV2.
Tbh, I didn't test that with the other versions.
It does react to mouse input, as I can use the info button.

Audio works for both the standalone and the LV2

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

For a quick update, I managed to complete some yc20 builds using clang.
I made a quick benchmark of faust1 vs faust2 to check for performance regression.
And there seems to be regression. See: faust2 is the longest running (top)
(I made sure to generate faust2 with -vec)

benchmark2

I can not change parameters in the standalone version,but I can in the LV2.

Ok let me try it on my side

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

I can not change parameters in the standalone version,but I can in the LV2.

I'm afraid I have no such problem on my side with manipulating parameters by GUI on the standalone Jack variant. Jack2, GTK+2, on current Archlinux.

When you edit a parameter by mouse, do you hear the effect of the parameter change and it's just GUI not updating its display? because I did experience such a bug for which I submitted a previous fix

@magnetophon
Copy link
Author

magnetophon commented Mar 24, 2018

I did some more testing.
Actually, I can change parameters, but the GUI only updates after a midi event.
Shall I make a separate issue for that?

The title of the fix you linked says it's for LV2, whereas I'm having the problem only with the standalone.

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

Yes make it a separate issue.
Same problem which I have fixed in Lv2, but I never experienced it in the standalone.
The fix is probably of the same nature. It must instruct the GUI to force redraw when an interaction is made. Let me look.

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

patch
Changes of lv2 ported to standalone UI. Does applying this fix your display problem?

@magnetophon
Copy link
Author

Yes, that fixes it.

Many thanks for your quick and helpful responses!

If you could do a release, I can close this issue and #6, and then add foo-yc20 back to NixOS.

@jpcima
Copy link
Collaborator

jpcima commented Mar 24, 2018

If you could do a release, I can close this issue and #6, and then add foo-yc20 back to NixOS.

I wish this as much as you do but I'm not a person in power to do that. Wait for @sampov2's input about this.

@magnetophon
Copy link
Author

I was kind of expecting this answer, but wanted to ask anyway.
I'll wait, np.

Thanks!

@magnetophon
Copy link
Author

@sampov2 Any news on this?

@sampov2
Copy link
Owner

sampov2 commented Aug 20, 2018

Sorry, there's no news on my part. I don't have a working development environment for the software at the moment. I'm happy to accept pull requests or offer collaboration rights if you're able to work on these fixes. Is PR #12 tested and working?

@magnetophon
Copy link
Author

magnetophon commented Aug 24, 2018

@sampov2 Thanks!

Is PR #12 tested and working?

Yes it is.
This Branch fixes faust v2 support.

I suggest you give @jpcima collaboration rights.

@jpcima
Copy link
Collaborator

jpcima commented Aug 24, 2018

@sampov2 the PR #12 works on each of our respective sides, but for the time being you'll have to take our word for it unfortunately.
I would be careful about faust2 use, as my own attempt has created a performance degradation. It would be wise to benchmark the system again before deciding on taking such a step.

Now, I can maybe help with the testing situation. (here was a mention of enabling automatic builds #9)
I've developed a skill at semaphore continuous integration on my own plugins. If that may help, I could attempt a setup for foo-yc20. I made such automatic builds as this and this.

@sampov2
Copy link
Owner

sampov2 commented Aug 24, 2018

Automatic builds would be great! I'll add you as a collaborator.

It would be especially great if that could be achieved for the Windows and Mac VST's since those builds are especially tricky. But of course the primary goal should be the Linux builds and everything else on top of that is just sugar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants