-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and bugfix for LV2 support #11
Conversation
update: I have found how to keep the oscillator table pointer in the DSP object. |
Thanks for the pull request. Unfortunately I don't have a development environment where I would be able to test this. @trebmuh - have you been able to test these fixes? My main question is that did we lose any functionality? For example, is the MIDI support still there? |
I have tested LV2 and standalone with Midi under Linux+Jack. There is no change in relation with Jack Midi, however LV2 has needed a transition from the old Event extension to Atom. |
Thanks. Let me know if you're successful in testing the VST support. |
I tested the VST in 2 configurations: dssi-vst (Wine) and VSTHost for Windows. I could add some maintainance needed in other commits. (mingw has evolved a lot but much of the foo-yc20 code is a few years old). |
Looks good. Thanks for the work! |
As for the mingw stuff, it would be great if there was an online build service that offered mingw support that we could use to produce the DLL's. Do you happen to know if there are any available? |
I am afraid not, I am not familiar with such services. |
I found a docker project that has containers with crosscompilers: https://github.com/dockcross/dockcross . This could be very good option as containers could offer a stable compilation environment to perform repeatable builds. |
I have updated foo-yc20 to support the latest faust 0.9.x and modern LV2.
The LV2 used extensions which are long deprecated and not supported in Jalv.
I believe this should fix issues #6 and #7.
This is how the implementation is affected by changes.
minimal.cpp
. Under the new faust it produced a dummymain()
function which is in conflict with the code of foo-yc20.I converted these tables from global to one per instance.
I make the oscillator pointer thread-local to keep the code like it is, but protect if there are concurrent runs. This thread-local may introduce a small runtime cost, which I have not measured.