Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of brillvm as library #324

Closed
wants to merge 14 commits into from

Conversation

oflatt
Copy link
Contributor

@oflatt oflatt commented May 10, 2024

This PR refactors rust brillvm a little to allow use as a library. It depends on pr #319, so the diff includes that work as well.

@Pat-Lafon
Copy link
Contributor

Hmm, this seems a little awkward to me. Are you doing this because you don't want to call brillvm via https://doc.rust-lang.org/std/process/struct.Command.html nor want to re-implement/specialize a version of the main file to your use?(The main part of brillvm, create_module_from_program, is publicly exposed in lib)

@oflatt
Copy link
Contributor Author

oflatt commented May 10, 2024

Yeah, we don't want to call brillvm via a process.
I see what you mean- we just need to call create_module_from_program. I'll do that instead.

@oflatt oflatt closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants