Skip to content

Conversation

@lindenb
Copy link
Contributor

@lindenb lindenb commented Apr 15, 2025

Description

This PR adds a support for GTF files.

The classes Gff3BaseData, Gff3FeatureImpl, Gff3Feature are used for the GTFCodec. I didn't want to write a class 'GtfFeature' as the classes would be identical.

AbstractGxxCodec is now the base class for Gff3Codec and GtfCodec.

AbstractGxxConstants is now the base class for Gff3Constants and GtfConstants.

AbstractGxxWriter is now the base class for Gff3Writer and GtfWriter

GtfCodec builds a tree using the attributes gene_id and transcript_id.

Test for GtfCodecTest and GtfWriterTest have been added.

The code was formatted in eclipse using "java-style-eclipse.xml"

Things to think about before submitting:

  • Make sure your changes compile and new tests pass locally.
  • Add new tests or update existing ones:
    • A bug fix should include a test that previously would have failed and passes now.
    • New features should come with new tests that exercise and validate the new functionality.
  • Extended the README / documentation, if necessary
  • Check your code style.
  • Write a clear commit title and message
    • The commit message should describe what changed and is targeted at htsjdk developers
    • Breaking changes should be mentioned in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant