Palautteet Google Sheetsiin | Antti/feedbacks-to-google-sheets #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be 'dangerous' so most likely will be changed
…and _isSheetsRequestBodyGiven methods
…n to handle data sending to Google API
…ave no effect, they have been deleted
…in why this was done
…date CHECK THIS comment
anttiasmala
commented
Oct 16, 2024
anttiasmala
commented
Oct 16, 2024
…smala/lahjalista into antti/feedbacks-to-google-sheets
anttiasmala
commented
Oct 16, 2024
anttiasmala
commented
Oct 16, 2024
anttiasmala
commented
Oct 16, 2024
samuliasmala
requested changes
Oct 20, 2024
anttiasmala
commented
Oct 21, 2024
anttiasmala
commented
Oct 21, 2024
Comment on lines
20
to
38
| export async function sendFeedbackToGoogleSheets({ | ||
| feedbackText, | ||
| userDetails, | ||
| }: { | ||
| feedbackText: string; | ||
| userUUID: string; | ||
| userDetails: User; | ||
| }) { | ||
| const date = `${new Date().toLocaleDateString('fi-FI')} ${new Date().toTimeString()}`; | ||
| const feedbackGiverDetails = `${userDetails.firstName} ${userDetails.lastName}\n${userDetails.email}`; | ||
| await SHEETS.spreadsheets.values.append({ | ||
| auth: AUTHENTICATION, | ||
| spreadsheetId: SPREADSHEET_ID, | ||
| range: `Palautteet!A:C`, | ||
| requestBody: { | ||
| majorDimension: 'ROWS', | ||
| values: [[props.feedbackText, props.userUUID, date]], | ||
| values: [[feedbackText, feedbackGiverDetails, date]], | ||
| }, | ||
| valueInputOption: 'USER_ENTERED', | ||
| }); |
There was a problem hiding this comment.
Vaihdoin propsin "suoriin variable nimiin". Tein lisäksi oman variablen, jossa määritetään nuo tiedot palautteen antajasta
Olisiko tästä
range: `Palautteet!A:C`,tarpeellista tehdä geneeristä vai onko "kovakoodattu" ok? 😄
There was a problem hiding this comment.
Kovakoodattu on ok tässä, ohjeistit tuon sheetin nimen readme-tiedostossa hyvin.
samuliasmala
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensimmäiset versiot (Class- ja "funktio"-versio) Googlen API:n käyttämisestä. Voidaan vaihtaa käyttämään Make.comia, jos tulee tarve