Replace default loading text with skeleton #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @joseph-bayer . Apologies that I'm just now looking at this. This is a really good start. As a thought experiment, I'm kind of thinking that the loading component should wrap Viewer here: https://github.com/samvera-labs/clover-iiif/blob/main/src/components/Viewer/index.tsx#L234-L241 In this model, the |
mathewjordan
force-pushed
the
main
branch
3 times, most recently
from
a9af10c to
a90ceb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy!
This is part 2 of our efforts to change how the Viewer loading state looks.
The pull request to support custom components for the loading state can be found here.
This pull request is focused on updating the default loading state with a loading skeleton!
The skeleton will even adjust when the information panel is open by default.
If you'd like for me to update the way it looks or further modify the skeleton based on the configuration, just let me know!