Moved 'local' variables from ViewerContent to context store and retri… #281
+52
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eved props from ViewerState in Content.tsx and ViewerContent
mathewjordan
force-pushed
the
main
branch
3 times, most recently
from
a9af10c to
a90ceb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eved props from ViewerState in Content.tsx and ViewerContent.
ViewerContent should now later on more easily convert to a subcomponent Viewer.Content. Props are still being passed unnecessarily to children of ViewerContent, but we can address that in separate clean up PRs.