Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set font-size CSS in metadata display component and cleanup #747

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Set font-size CSS in metadata display component and cleanup #747

merged 3 commits into from
Dec 6, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Dec 3, 2024

Related issue: #724

@Dananji Dananji marked this pull request as ready for review December 4, 2024 21:28
cjcolvar
cjcolvar approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell. With these changes in a number of places would it make sense to make a variable (or set of variables like $fontSizeLarge, $fontSizeMedium, etc.) or does Bootstrap have variables for this already?

@Dananji
Copy link
Collaborator Author

Dananji commented Dec 6, 2024 •
edited
Loading

Yes, creating variables for specific font-size values sounds good! I'll work on that.
No, Ramp doesn't use any CSS frameworks at the moment. So, we would define these as sass variables in the _vars.scss

cjcolvar
cjcolvar approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Dananji Dananji merged commit 530797e into main Dec 6, 2024
2 checks passed
@Dananji Dananji deleted the zoom-in-fonts branch December 6, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dananji @cjcolvar