Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display line breaks within a cue for WebVTT and SRT transcripts #755

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Dananji
Copy link
Collaborator

@Dananji Dananji commented Dec 17, 2024

Related issue: #750

For the following WebVTT file the display looks as follows;

1
00:00:01.200 --> 00:00:21.000 region:fred align:left
[music]

NOTE End of music, and starting dialog

2
00:00:22.200 --> 00:00:26.600 region:bill align:right
<em>Just</em> before lunch one day, a puppet show 
was put on at school.

3
00:00:26.700 --> 00:00:31.500 region:fred align:left
It was called "Mister Bungle Goes to Lunch".

4
00:00:31.600 --> 00:00:34.500
It was fun to watch.

5
00:00:36.100 --> 00:00:41.300
In the puppet show, Mr. Bungle came to the 
boys' room on his way to lunch.

6
00:00:41.400 --> 00:00:46.200
He looked at his hands. His hands were dirty 
and his hair was messy.

7
00:00:46.300 --> 00:00:51.100
But Mr. Bungle didn't stop to wash his hands 
or comb his hair.
Before After
Screenshot 2024-12-17 at 10 11 40 AM Screenshot 2024-12-17 at 10 11 06 AM

Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Dananji Dananji merged commit ac213fb into main Dec 17, 2024
2 checks passed
@Dananji Dananji deleted the vtt-linebreaks branch December 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants