DRY up require 'spec_helper' from tests

Keep it clean.

.rspec

@@ -1 +1,2 @@
---colour
+--color
+--require spec_helper

spec/actors/create_with_files_actor_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::CreateWithFilesActor do
   let(:create_actor) { double('create actor', create: true,
                                               curation_concern: work,

spec/actors/sufia/create_with_remote_files_actor_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::CreateWithRemoteFilesActor do
   let(:create_actor) { double('create actor', create: true,
                                               curation_concern: work,

spec/config/sufia_events_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "sufia_events using CurationConcerns callbacks" do
   let(:curation_concern) { create(:work) }
   let(:file_set) { create(:file_set) }

spec/controllers/admin_stats_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Admin::StatsController, type: :controller do
   let(:user1) { create(:user) }
 

spec/controllers/api/items_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe API::ItemsController, type: :controller do
   let(:arkivo_actor) { double Sufia::Arkivo::Actor }
 

spec/controllers/api/zotero_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe API::ZoteroController, type: :controller do
   let(:user) { create(:user) }
 

spec/controllers/authorities_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe AuthoritiesController, type: :controller do
   describe "#query" do
     it "returns an array of hashes" do

spec/controllers/batch_edits_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe BatchEditsController, type: :controller do
   let(:user) { create(:user) }
   before do

spec/controllers/catalog_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe CatalogController, type: :controller do
   routes { Rails.application.class.routes }
 

spec/controllers/citations_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe CitationsController do
   let(:user) { create(:user) }
 

spec/controllers/collections_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe CollectionsController do
   routes { Rails.application.routes }
   before { allow_any_instance_of(User).to receive(:groups).and_return([]) }

spec/controllers/content_blocks_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ContentBlocksController, type: :controller do
   describe "#update" do
     let(:content_block) { FactoryGirl.create(:content_block) }

spec/controllers/curation_concerns/audits_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 
 describe CurationConcerns::AuditsController do
   routes { Sufia::Engine.routes }

spec/controllers/dashboard_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe DashboardController, type: :controller do
   context "with an unauthenticated user" do
     it "redirects to sign-in page" do

spec/controllers/depositors_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe DepositorsController do
   let(:user) { create(:user) }
   let(:grantee) { create(:user) }

spec/controllers/downloads_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe DownloadsController, type: :controller do
   routes { Rails.application.routes }
   describe "with a file" do

spec/controllers/featured_work_lists_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe FeaturedWorkListsController, type: :controller do
   describe "#create" do
     before do

spec/controllers/featured_works_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe FeaturedWorksController, type: :controller do
   describe "#create" do
     before do

spec/controllers/file_sets_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe CurationConcerns::FileSetsController do
   routes { Rails.application.routes }
   let(:user) { create(:user) }

spec/controllers/generic_works_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe CurationConcerns::GenericWorksController do
   let(:user) { create(:user) }
 

spec/controllers/homepage_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::HomepageController, type: :controller do
   routes { Sufia::Engine.routes }
 

spec/controllers/mailbox_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe MailboxController, type: :controller do
   let(:mock_box) { {} }
 

spec/controllers/my/collections_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe My::CollectionsController, type: :controller do
   describe "logged in user" do
     let(:user)  { create(:user) }

spec/controllers/my/highlights_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 
 describe My::HighlightsController, type: :controller do
   describe "logged in user" do

spec/controllers/my/shares_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 
 describe My::SharesController, type: :controller do
   describe "logged in user" do

spec/controllers/my/works_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 
 describe My::WorksController, type: :controller do
   let(:user) { create(:user) }

spec/controllers/my_controller_spec.rb

@@ -1,4 +1,2 @@
-require 'spec_helper'
-
 describe MyController, type: :controller do
 end

spec/controllers/pages_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe PagesController, type: :controller do
   let(:page_name) { "about_page" }
   context "content exists" do

spec/controllers/static_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe StaticController, type: :controller do
   routes { Sufia::Engine.routes }
   describe "#mendeley" do

spec/controllers/stats_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe StatsController do
   let(:user) { create(:user) }
   before do

spec/controllers/sufia/batch_uploads_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::BatchUploadsController do
   let(:user) { create(:user) }
   before do

spec/controllers/sufia/uploads_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 
 describe Sufia::UploadsController do
   let(:user) { create(:user) }

spec/controllers/tinymce_assets_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe TinymceAssetsController, type: :controller do
   let(:file) { fixture_file_upload('/world.png', 'image/png') }
 

spec/controllers/transfers_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe TransfersController, type: :controller do
   describe "with a signed in user" do
     let(:another_user) { create(:user) }

spec/controllers/users_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe UsersController, type: :controller do
   let(:user) { FactoryGirl.create(:user) }
   before(:each) do

spec/features/batch_edit_spec.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-require 'spec_helper'
 
 describe 'Batch management of works', type: :feature do
   let(:current_user) { create(:user) }

spec/features/browse_catalog_spec.rb

@@ -1,5 +1,4 @@
 # coding: utf-8
-require 'spec_helper'
 
 describe "Browse catalog:", type: :feature do
   let!(:jills_work) do

spec/features/browse_dashboard_files_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "Browse Dashboard", type: :feature do
   let(:user) { FactoryGirl.create(:user) }
   let!(:dissertation) { FactoryGirl.create(:public_work, user: user, title: ["Fake PDF Title"], subject: %w(lorem ipsum dolor sit amet)) }

spec/features/catalog_search_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe 'catalog searching', type: :feature do
   before do
     allow(User).to receive(:find_by_user_key).and_return(stub_model(User, twitter_handle: 'bob'))

spec/features/cloud_upload_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "Selecting files to import from cloud providers", type: :feature do
   before do
     sign_in :user

spec/features/collection_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe 'collection', type: :feature do
   let(:user) { create(:user) }
 

spec/features/contact_form_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "Sending an email via the contact form", type: :feature do
   before do
     sign_in :user_with_fixtures

spec/features/create_work_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Creating a new Work', :js do
   let(:user) { create(:user) }
   let(:file1) { File.open(fixture_path + '/world.png') }

spec/features/display_dashboard_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "The Dashboard", type: :feature do
   before do
     sign_in :user_with_fixtures

spec/features/edit_file_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "Editing a file:", type: :feature do
   let(:user) { create(:user) }
   let(:file_title) { 'Some kind of title' }

spec/features/edit_work_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Editing a work', type: :feature do
   let(:user) { create(:user) }
   let(:work) { build(:work, user: user) }

spec/features/notifications_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "Notifications page", type: :feature do
   before do
     sign_in FactoryGirl.create(:user_with_mail)

spec/features/ownership_transfer_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 include Selectors::Header
 include Selectors::Dashboard
 include Selectors::NewTransfers

spec/features/proxy_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe 'proxy', type: :feature do
   let(:user) { create(:user) }
   let(:second_user) { create(:user) }

spec/features/search_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe 'searching' do
   let(:user) { create :user }
   let(:subject_value) { 'fffzzz' }

spec/features/users_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "User Profile", type: :feature do
   before do
     sign_in user

spec/features/work_show_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe "display a work as its owner" do
   let(:work_path) { "/concern/generic_works/#{work.id}" }
 

spec/forms/curation_concerns/work_form_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe CurationConcerns::GenericWorkForm do
   let(:work) { GenericWork.new }
   let(:form) { described_class.new(work, nil) }

spec/forms/sufia/batch_edit_form_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::Forms::BatchEditForm do
   let(:model) { GenericWork.new }
   let(:work1) { create :generic_work, title: ["title 1"], keyword: ["abc"], creator: ["Wilma"], language: ['en'], contributor: ['contributor1'], description: ['description1'], rights: ['rights1'], subject: ['subject1'], identifier: ['id1'], based_near: ['based_near1'], related_url: ['related_url1'] }

spec/forms/sufia/batch_upload_form_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::BatchUploadForm do
   let(:model) { GenericWork.new }
   let(:form) { described_class.new(model, ability) }

spec/forms/sufia/collection_form_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Sufia::Forms::CollectionForm do
   describe "#terms" do
     subject { described_class.terms }

spec/helpers/batch_edits_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe BatchEditsHelper, type: :helper do
   describe "#render_check_all" do
     before do

spec/helpers/content_block_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ContentBlockHelper, type: :helper do
   let(:content_block) { FactoryGirl.create(:content_block, value: "<p>foo bar</p>") }
 

spec/helpers/dashboard_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe DashboardHelper, type: :helper do
   describe "#render_recent_activity" do
     context "when there is no activity" do

spec/helpers/file_set_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe FileSetHelper, type: :helper do
   describe '#display_multiple' do
     subject { helper.display_multiple(['Title with < 50Hz frequency. http://www.example.com. & More text', 'Other title']) }

spec/helpers/generic_work_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe GenericWorkHelper do
   describe '#render_collection_links' do
     let!(:work_doc) { SolrDocument.new(id: '123', title_tesim: ['My GenericWork']) }

spec/helpers/sufia_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe SufiaHelper, type: :helper do
   describe "show_transfer_request_title" do
     let(:sender) { create(:user) }

spec/helpers/sufia_url_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe SufiaUrlHelper do
   let(:document) { SolrDocument.new(id: 'foo123') }
 

spec/helpers/trophy_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe TrophyHelper, type: :helper do
   describe "#display_trophy_link" do
     let(:user) { FactoryGirl.create(:user) }

spec/javascripts/jasmine_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 require 'rake'
 
 # Run the jasmine tests by running the jasmine:ci rake command and parses the output for failures.

spec/jobs/attach_files_to_work_job_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe AttachFilesToWorkJob do
   context "happy path" do
     let(:file1) { File.open(fixture_path + '/world.png') }

spec/jobs/batch_create_job_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe BatchCreateJob do
   let(:user) { create(:user) }
   let(:log) { create(:batch_create_operation, user: user) }