Overriding Rails config defaults for compatibility (#7016)

* Set modified defaults during hyrax app generation

* Move Rails configuration default overrides into a Hyrax managed initializer

* Overriding action_view defaults resulting in test failures

* Overriding action_controller defaults to allow open redirects

* Overriding action_view sanitizer default back to HTML4, extra char encoding breaks test comparisons

* Adding allow_other_host option to intentional open redirects instead of overriding raise_on_open_redirects config default

---------

Co-authored-by: Daniel Pierce <[email protected]>

.dassie/config/application.rb

@@ -9,7 +9,8 @@
 module Dassie
   class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.
-    config.load_defaults 6.0
+    config.load_defaults 7.2
+    config.add_autoload_paths_to_load_path = true
 
     # Settings in config/environments/* take precedence over those specified here.
     # Application configuration can go into files in config/initializers

.koppie/config/application.rb

@@ -9,7 +9,8 @@
 module Koppie
   class Application < Rails::Application
     # Initialize configuration defaults for originally generated Rails version.
-    config.load_defaults 6.0
+    config.load_defaults 7.2
+    config.add_autoload_paths_to_load_path = true
 
     # Settings in config/environments/* take precedence over those specified here.
     # Application configuration can go into files in config/initializers

app/controllers/hyrax/api/zotero_controller.rb

@@ -14,7 +14,7 @@ def initiate
         session[:request_token] = request_token
         current_user.zotero_token = request_token
         current_user.save
-        redirect_to request_token.authorize_url(identity: '1', oauth_callback: callback_url)
+        redirect_to request_token.authorize_url(identity: '1', oauth_callback: callback_url), allow_other_host: true
       rescue OAuth::Unauthorized
         redirect_to root_url, alert: 'Invalid Zotero client key pair'
       end

config/initializers/new_framework_defaults_7_2.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+# Any options set here are to override Rails 7.2 configuration defaults
+
+# These fix a couple of issues arising from Rails 7.2 enforcement of HTML5 semantics
+# by default when using certain Rails methods
+Rails.application.config.action_view.button_to_generates_button_tag = false
+Rails.application.config.action_view.sanitizer_vendor = Rails::HTML4::Sanitizer

lib/generators/hyrax/install_generator.rb

@@ -188,7 +188,7 @@ def riiif_image_server
       generate 'hyrax:riiif' unless options[:'skip-riiif']
     end
 
-    def insert_env_queue_adapter
+    def insert_application_config
       insert_into_file 'config/application.rb', after: /config\.load_defaults [0-9.]+$/ do
         "\n    config.active_job.queue_adapter = ENV.fetch('HYRAX_ACTIVE_JOB_QUEUE') { 'async' }.to_sym\n"
       end

template.rb

@@ -1,4 +1,9 @@
 # frozen_string_literal: true
+
+insert_into_file 'config/application.rb', after: /config\.load_defaults [0-9.]+$/ do
+  "\n    config.add_autoload_paths_to_load_path = true"
+end
+
 gem 'hyrax', '5.0.3'
 run 'bundle install'
 generate 'hyrax:install', '-f'