[email protected]

[davidchambers]

This pull request adds TypeClass values for Alt, Plus, and Alternative, and functions for fantasy-land/alt and fantasy-land/zero, all of which were added in fantasyland/fantasy-land#197.

Please review this when you have some time, @safareli. :)

[safareli]

If Array is alternative String could be Alternative in the same way too.

list/Array/String we could have other instance, which just does concatenation. In purescript and GHC (search Alternative []) we have that concatenative version so maybe it's better to stay consistent with them?

I could not find implementation of alternative for Map nor in PS nor in Haskell , but If we follow use concatenation as alt for string and array maybe we should do same for StrMap ?

[davidchambers]

Thanks for the feedback, @safareli. I've updated the patch. Could you take another look?

If Array is alternative String could be Alternative in the same way too.

Can it, though? String does not satisfy the requirements of Functor.

[safareli]

Can it, though? String does not satisfy the requirements of Functor.

oh, yes :d

[safareli]

I think it should be true

[davidchambers]

I don't think so. We can't define fantasy-land/of for Object, so Object can't satisfy Applicative.

[safareli]

oh, yes, again

[safareli]

LGTM