Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move type identifiers from type representatives to members #38

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

davidchambers
Copy link
Member

This specification currently reuses the type representatives defined in the Fantasy Land specification. In fantasyland/fantasy-land#315 I have proposed changing the property name from 'constructor' to 'fantasy-land'. The proposal is likely to be accepted, at which point members of algebraic data types would need two different “type representatives” to be compatible with both specifications.

A type identifier need not be defined on a type representative; attaching it to each member would work equally well. This pull request removes all references to type representatives, disentangling this specification from the Fantasy Land specification.

Copy link
Member

@Avaq Avaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move forward with this. I will address my concerns about adoption once they come up.

@davidchambers davidchambers merged commit a87cb8e into master Nov 3, 2019
@davidchambers davidchambers deleted the davidchambers/no-type-reps branch November 3, 2019 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants