removed undecided string everywhere and replaced with cosntants

sandboxnu · Feb 4, 2025 · 99012a6 · 99012a6
1 parent f6e43d3
commit 99012a6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/packages/api/src/major/major.service.ts b/packages/api/src/major/major.service.ts
@@ -4,6 +4,7 @@ import {
   SupportedMajors,
   SupportedConcentrations,
 } from "@graduate/common";
+import { UNDECIDED } from "@graduate/common/dist/constants";
 import { Injectable, Logger } from "@nestjs/common";
 import { formatServiceCtx } from "../utils";
 import { MAJOR_YEARS, MAJORS } from "./major-collator";
@@ -122,7 +123,7 @@ export class MajorService {
 
     const isValidConcentrationName =
       concentrations.includes(concentrationName) ||
-      concentrationName === "Undecided";
+      concentrationName === UNDECIDED;
 
     if (!isValidConcentrationName) {
       this.logger.debug(

diff --git a/packages/frontend/components/Sidebar/Sidebar.tsx b/packages/frontend/components/Sidebar/Sidebar.tsx
@@ -11,6 +11,8 @@ import {
   getAllCoursesFromPlan,
   getSectionError,
   getAllCoursesInMajor,
+  UNDECIDED_CONCENTRATION,
+  UNDECIDED,
 } from "../../utils";
 import {
   handleApiClientError,
@@ -210,8 +212,8 @@ const Sidebar: React.FC<SidebarProps> = memo(
       <SidebarContainer
         title={major.name}
         subtitle={
-          selectedPlan.concentration === "Undecided"
-            ? "Concentration Undecided"
+          selectedPlan.concentration === UNDECIDED
+            ? UNDECIDED_CONCENTRATION
             : selectedPlan.concentration
         }
         creditsTaken={creditsTaken}

diff --git a/packages/frontend/utils/constants.ts b/packages/frontend/utils/constants.ts
@@ -11,6 +11,7 @@ export const BETA_MAJOR_TOOLTIP_MSG =
 export const GEN_PLACEHOLDER_MSG =
   "General Placeholderse are generic courses that you can place in your plan if you do not know yet what to take but want the requirements to be fulfilled";
 export const UNDECIDED_CONCENTRATION = "Concentration Undecided";
+export const UNDECIDED = "Undecided";
 
 export const defaultGuestStudent: GetStudentResponse = {
   uuid: undefined,