-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bcrypt version #802
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a lot of packages changed. what are the removed ones?
"bcrypt@npm:5.0.0": | ||
version: 5.0.0 | ||
resolution: "bcrypt@npm:5.0.0" | ||
"bcrypt@npm:5.1.1": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denniwang it looks like bcrypt adds a new dependency that introduces additional dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unlucky, hopefully it doesnt slow down performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
updating bcrypt version
Closes # (issue number)
Type of change
Please tick the boxes that best match your changes.
yarn install
yarn dev:migration:run
How Has This Been Tested?
Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.
Checklist: