Fix account creation bug on login page #3

sandeepsalwan1 · 2025-09-17T17:58:21Z

Fix user registration by adding server-side duplicate email checks and improving client-side async handling and error feedback.

Summary by cubic

Fixes account creation on the login page by blocking duplicate emails on the server and improving the form’s async flow and error handling. Users now get clear feedback, and successful register/login redirects to /users without flaky states.

Bug Fixes
- API: check existing user by email and return 409 with a JSON error.
- API: handle Prisma P2002 to prevent race-condition duplicates.
- AuthForm: make submit async and separate REGISTER vs LOGIN logic.
- Show specific toasts for duplicate email, invalid credentials, and generic errors; redirect to /users on success.

Co-authored-by: salwansandeep5 <[email protected]>

cursor · 2025-09-17T17:58:22Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

vercel · 2025-09-17T17:58:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
ai-message	Ready	Preview	Comment	Sep 17, 2025 7:24pm

Copilot

Pull Request Overview

This PR fixes account creation bugs on the login page by implementing proper duplicate email validation and improving async error handling. The changes prevent users from creating duplicate accounts and provide better feedback during the registration process.

Key changes:

Added server-side duplicate email validation with proper error responses
Converted form submission to async/await pattern for better error handling
Implemented specific error messages for different failure scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
app/api/register/route.ts	Added duplicate email checks and Prisma race condition handling
app/(site)/components/AuthForm.tsx	Converted to async form submission with improved error handling and user feedback

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-17T18:52:20Z

app/(site)/components/AuthForm.tsx

+        if (err?.response?.status === 409) {
+          toast.error("Email already registered");
+        } else if (err?.response?.data) {
+          toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed');


The error handling logic for err.response.data is overly complex. Consider simplifying this by either extracting the error message consistently or using a more straightforward fallback approach.

Suggested change

toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed');

const errorMessage =

typeof err.response.data === 'string'

? err.response.data

: err.response.data.message

? err.response.data.message

: 'Registration failed';

toast.error(errorMessage);

Copilot · 2025-09-17T18:52:21Z

app/(site)/components/AuthForm.tsx

+      const callback = await signIn("credentials", {
+        email: data.email,
+        password: data.password,
+        redirect: false,
+      });
+
+      if (callback?.error) {
+        toast.error("Invalid credentials!");
+      }
+      if (callback?.ok && !callback?.error) {
+        toast.success("Logged in!");
+        router.push("/users");
+      }
+      setIsLoading(false);


The setIsLoading(false) call is duplicated across both REGISTER and LOGIN branches. Consider moving this to a single location or using a try/finally block to ensure it's always called.

sandeepsalwan1 · 2025-09-17T18:56:11Z

@cursoragent @cursor it doesn't work it just says error while creating user when I try making an account test driven development you check what's going on fix where's the error also

cursor · 2025-09-17T18:56:18Z

I significantly enhanced the robustness of user authentication and registration. This involved improving client-side error message display, ensuring consistent loading state management, and implementing comprehensive server-side input validation and error handling for the registration API, including specific Prisma error detection and detailed logging. I also fixed a critical typo in the bcrypt import.

In app/api/register/route.ts, I implemented robust server-side input validation, checking for DATABASE_URL presence, valid email format using a regex, and a minimum password length of 6 characters. I also refactored error handling to use NextResponse.json for all responses and added specific handling for Prisma.PrismaClientKnownRequestError (e.g., P2002 for duplicate emails) and other Prisma connection errors (P10xx).
In app/(site)/components/AuthForm.tsx, I enhanced client-side error message display for registration failures by checking err.response.data.error or err.response.data.message for more specific backend messages. I also wrapped the login signIn call in a try...finally block to guarantee setIsLoading(false) is always called, preventing the UI from getting stuck in a loading state.
In app/api/auth/[...nextauth]/route.ts, I corrected a critical typo from brcypt to bcrypt in the authOptions configuration, ensuring proper password hashing and comparison during authentication.

2 tasks completed

Add detailed error responses and validation to register API
Fix bcrypt import typo in NextAuth credentials provider

_{Learn more about Cursor Agents}

cursor

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursor · 2025-09-17T18:59:51Z

app/(site)/components/AuthForm.tsx

+      }
+      setIsLoading(false);
+      return;
+    }


Bug: Login Flow Fails to Reset Loading State

The LOGIN flow's signIn call lacks try-catch error handling. If signIn throws an exception, setIsLoading(false) isn't reached, leaving the form stuck in a loading state. This differs from the REGISTER flow, which correctly uses finally to reset the loading state.

Co-authored-by: salwansandeep5 <[email protected]>

sandeepsalwan1 · 2025-09-17T19:04:06Z

@cursor it still says error while registering user when making an account fix

cursor · 2025-09-17T19:04:10Z

I enhanced the application's database error handling to provide more specific diagnostics and hints for common issues like connection failures or unapplied migrations. I also updated the build process to ensure database migrations are always deployed before the application build.

I modified the build script in package.json from next build to prisma migrate deploy && next build. This ensures that Prisma database migrations are applied automatically during the build process, which is crucial for deployment environments.
In app/api/register/route.ts, I significantly improved database error handling:
- I updated the response for Prisma P10xx connection errors to include the specific code and a hint regarding Aiven MySQL SSL settings.
- I implemented new error detection for unmigrated databases, checking for messages like 'doesn\'t exist' or 'no such table', and providing a hint to run npx prisma migrate deploy.
- I added specific handling for low-level network errors such as ECONNREFUSED or ETIMEDOUT, offering guidance to check host, port, firewall, and SSL requirements.

_{Learn more about Cursor Agents}

Co-authored-by: salwansandeep5 <[email protected]>

cubic-dev-ai

2 issues found across 2 files

Prompt for AI agents (all 2 issues)


Understand the root cause of the following 2 issues and fix them.


<file name="app/(site)/components/AuthForm.tsx">

<violation number="1" location="app/(site)/components/AuthForm.tsx:61">
Ensure the LOGIN signIn call is wrapped in a try/finally (or handles rejection) so setIsLoading(false) always runs; otherwise a thrown error will leave the form stuck in a loading state.</violation>

<violation number="2" location="app/(site)/components/AuthForm.tsx:77">
Avoid displaying raw server error messages to users; show a generic message instead to prevent leaking internal details.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

cubic-dev-ai · 2025-09-17T19:08:21Z

app/(site)/components/AuthForm.tsx

+        if (err?.response?.status === 409) {
+          toast.error("Email already registered");
+        } else if (err?.response?.data) {
+          toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed');


Avoid displaying raw server error messages to users; show a generic message instead to prevent leaking internal details.

Prompt for AI agents

Address the following comment on app/(site)/components/AuthForm.tsx at line 77: <comment>Avoid displaying raw server error messages to users; show a generic message instead to prevent leaking internal details.</comment> <file context> @@ -56,33 +56,51 @@ const AuthForm = () => { + if (err?.response?.status === 409) { + toast.error("Email already registered"); + } else if (err?.response?.data) { + toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed'); + } else { + toast.error("Something went wrong!"); </file context>

Suggested change

toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed');

toast.error("Registration failed");

cubic-dev-ai · 2025-09-17T19:08:21Z

app/(site)/components/AuthForm.tsx

-          toast.error("Something went wrong!");
+      try {
+        await axios.post("/api/register", data);
+        const callback = await signIn("credentials", {


Ensure the LOGIN signIn call is wrapped in a try/finally (or handles rejection) so setIsLoading(false) always runs; otherwise a thrown error will leave the form stuck in a loading state.

Prompt for AI agents

Address the following comment on app/(site)/components/AuthForm.tsx at line 61: <comment>Ensure the LOGIN signIn call is wrapped in a try/finally (or handles rejection) so setIsLoading(false) always runs; otherwise a thrown error will leave the form stuck in a loading state.</comment> <file context> @@ -56,33 +56,51 @@ const AuthForm = () => { - toast.error("Something went wrong!"); + try { + await axios.post("/api/register", data); + const callback = await signIn("credentials", { + email: data.email, + password: data.password, </file context>

Co-authored-by: salwansandeep5 <[email protected]>

sandeepsalwan1 · 2025-09-17T20:12:11Z

@cursor (index):1 Unchecked runtime.lastError: The message port closed before a response was received.Understand this error
h1-check.js:107 Uncaught (in promise) TypeError: Cannot convert undefined or null to object
at Object.keys ()
at h1-check.js:107:132888Understand this error
content.06af5f40.js:1 Content script loaded
content.06af5f40.js:9 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self' 'wasm-unsafe-eval' 'inline-speculation-rules' chrome-extension://40a6958c-93af-4d34-95fe-e3b873d106b2/". Either the 'unsafe-inline' keyword, a hash ('sha256-fLU4oopUyMxIxjYH7bIba3EIxPbBB9yGHQ0TeeJdMD4='), or a nonce ('nonce-...') is required to enable inline execution.

(anonymous) @ content.06af5f40.js:9Understand this error
feedback.html?dpl=dpl_7QkSYZbHfZdcShKZ4CyfJkwEks3k:1 Unchecked runtime.lastError: The message port closed before a response was received.Understand this error
content.06af5f40.js:9 Message received in content script: Object
content.06af5f40.js:9 Sending page content: Sign in to your account
Email
Password
Sign in
Or continue with
Don't have an account?
Register...
/api/pusher/auth:1 Failed to load resource: the server responded with a status of 401 ()Understand this error
/api/register:1 Failed to load resource: the server responded with a status of 400 ()Understand this error
/api/register:1 Failed to load resource: the server responded with a status of 500 ()

cursor · 2025-09-17T20:12:18Z

I've analyzed the console errors you provided and here's a breakdown of what's happening and how to fix your registration issue:

First, many of the errors you're seeing (like runtime.lastError, h1-check.js TypeError, and Refused to execute inline script) are related to browser extensions and not your application, so you can safely ignore those. The /api/pusher/auth 401 error is also normal before a user is logged in.

The critical errors are:

/api/register 400: This indicates that the data you're submitting in your registration form is invalid. The API now requires a non-empty name, a valid email format, and a password of at least 6 characters.
/api/register 500: This is a server-side error, most likely pointing to an issue with your database connection or setup.

To fix this, I've outlined a step-by-step process:

Step 1: Try registering with valid data. On your registration form, ensure you're using a brand new email (not previously registered), a name, and a password of at least 6 characters.
Step 2: Configure your database (Aiven). You'll need to add or update environment variables in your hosting environment (e.g., Vercel) for DATABASE_URL (your Aiven MySQL URI, potentially adjusting the sslaccept parameter), NEXTAUTH_SECRET, and MIGRATE_SECRET. After adding these, redeploy your application.
Step 3: Create the database tables. Once your environment variables are set and deployed, open a specific migration URL in your browser (e.g., https://YOUR-DEPLOYMENT/api/migrate?secret=my-safe-migrate-secret) to create the necessary tables. You should see a success message.
Step 4: Try registration again. Use a brand new email. If it still fails, check the network tab in your browser's developer tools for the /api/register request's response. This will give you a more specific error message (e.g., "Email already registered," "Database not migrated," or "Database connection error") that will guide you to the exact fix.

If you're still stuck, you can provide me with your deployment URL and a sanitized DATABASE_URL pattern (without passwords), or the JSON body from a failed /api/register response, and I can help pinpoint the issue more precisely.

_{Learn more about Cursor Agents}

Refactor AuthForm and register API to handle errors and duplicates

41b17a1

Co-authored-by: salwansandeep5 <[email protected]>

vercel bot deployed to Preview September 17, 2025 17:59 View deployment

sandeepsalwan1 requested a review from Copilot September 17, 2025 18:51

Copilot AI reviewed Sep 17, 2025

View reviewed changes

sandeepsalwan1 marked this pull request as ready for review September 17, 2025 18:57

cursor bot reviewed Sep 17, 2025

View reviewed changes

Refactor: Improve error handling and validation in auth and registration

db2cf0a

Co-authored-by: salwansandeep5 <[email protected]>

vercel bot deployed to Preview September 17, 2025 19:02 View deployment

feat: Improve database error handling and add migration to build

ce63710

Co-authored-by: salwansandeep5 <[email protected]>

vercel bot had a problem deploying to Preview September 17, 2025 19:06 Failure

cubic-dev-ai bot reviewed Sep 17, 2025

View reviewed changes

Refactor: Improve migration secret handling and DB SSL configuration

2d5b6fc

Co-authored-by: salwansandeep5 <[email protected]>

vercel bot deployed to Preview September 17, 2025 19:24 View deployment

-          toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed');
+          const errorMessage =
+            typeof err.response.data === 'string'
+              ? err.response.data
+              : err.response.data.message
+                ? err.response.data.message
+                : 'Registration failed';
+          toast.error(errorMessage);

	toast.error(typeof err.response.data === 'string' ? err.response.data : 'Registration failed');
	toast.error("Registration failed");

Fix account creation bug on login page #3

Are you sure you want to change the base?

Fix account creation bug on login page #3

Uh oh!

Conversation

sandeepsalwan1 commented Sep 17, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

cursor bot commented Sep 17, 2025

Uh oh!

vercel bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

sandeepsalwan1 commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

This PR is being reviewed by Cursor Bugbot

Uh oh!

cursor bot Sep 17, 2025

Choose a reason for hiding this comment

Bug: Login Flow Fails to Reset Loading State

Uh oh!

sandeepsalwan1 commented Sep 17, 2025

Uh oh!

cursor bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sandeepsalwan1 commented Sep 17, 2025

Uh oh!

cursor bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sandeepsalwan1 commented Sep 17, 2025 •

edited by cubic-dev-ai bot

Loading

vercel bot commented Sep 17, 2025 •

edited

Loading

sandeepsalwan1 commented Sep 17, 2025 •

edited

Loading

cursor bot commented Sep 17, 2025 •

edited

Loading

cursor bot commented Sep 17, 2025 •

edited

Loading

cubic-dev-ai bot Sep 17, 2025 •

edited

Loading

cubic-dev-ai bot Sep 17, 2025 •

edited

Loading

cursor bot commented Sep 17, 2025 •

edited

Loading