Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server nicknames #48

Merged
merged 10 commits into from
Aug 23, 2024
Merged

Server nicknames #48

merged 10 commits into from
Aug 23, 2024

Conversation

Aptimex
Copy link
Collaborator

@Aptimex Aptimex commented Aug 6, 2024

Deployed servers can now be given nicknames which will be displayed in the status command.

@Aptimex Aptimex requested a review from luker983 August 6, 2024 23:26
src/cmd/add_server.go Outdated Show resolved Hide resolved
src/cmd/status.go Outdated Show resolved Hide resolved
src/cmd/status.go Outdated Show resolved Hide resolved
src/peer/config.go Outdated Show resolved Hide resolved
@Aptimex
Copy link
Collaborator Author

Aptimex commented Aug 7, 2024

Got the nicknames stored in the E2EE config file instead; still need to actually test that it works with status, and probably still need more changes to make it work with the add server command.

@Aptimex
Copy link
Collaborator Author

Aptimex commented Aug 19, 2024

Got everything working client-side. Let me know if you have any other feedback now.

@Aptimex Aptimex linked an issue Aug 20, 2024 that may be closed by this pull request
Copy link
Collaborator

@luker983 luker983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few small comments but overall the client-side version is really clean!

src/peer/peer_config.go Outdated Show resolved Hide resolved
src/peer/peer_config.go Outdated Show resolved Hide resolved
src/peer/config.go Outdated Show resolved Hide resolved
src/peer/config.go Show resolved Hide resolved
@Aptimex Aptimex merged commit 84a9f79 into main Aug 23, 2024
3 checks passed
@Aptimex Aptimex deleted the server-nicknames branch August 23, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support server nicknames
2 participants