Skip to content

Commit

Permalink
Updated release notes for 0.1.6
Browse files Browse the repository at this point in the history
  • Loading branch information
sandreas committed Apr 23, 2024
1 parent 9604eb0 commit e157c93
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 20 deletions.
18 changes: 14 additions & 4 deletions tone/Metadata/Formats/FfmetadataFormat.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public class FfmetadataFormat : IMetadataFormat

private const string FfmetadataHeader = ";FFMETADATA";
private static readonly char[] CharsToEscape = { '=', ';', '#', '\\', '\n' };
/*
// TBPM=0,
// TMED=CD,
// language=eng,
Expand All @@ -35,7 +36,7 @@ public class FfmetadataFormat : IMetadataFormat
// lyrics-XXX (where XXX is either XXX or language code, e.g. -eng)
// disc
//

*/
/*
const AVMetadataConv ff_id3v2_34_metadata_conv[] = {
Expand All @@ -52,7 +53,8 @@ public class FfmetadataFormat : IMetadataFormat
{ "USLT", "lyrics" },
{ 0 }
};
*/
/*
const AVMetadataConv ff_id3v2_4_metadata_conv[] = {
{ "TCMP", "compilation" },
{ "TDRC", "date" },
Expand All @@ -64,7 +66,8 @@ public class FfmetadataFormat : IMetadataFormat
{ "TIT1", "grouping" },
{ 0 }
};
*/
/*
static const AVMetadataConv id3v2_2_metadata_conv[] = {
{ "TCP", "compilation" },
Expand Down Expand Up @@ -183,7 +186,7 @@ public class FfmetadataFormat : IMetadataFormat
// (MetadataProperty.Conductor, typeof(string), "",null),
(MetadataProperty.Copyright, typeof(string), "copyright",null),
(MetadataProperty.Description, typeof(string), "description",null),
// (MetadataProperty.DiscNumber, typeof(string), "album",null), // disc = 1/1
// (MetadataProperty.DiscNumber, typeof(int), "disc",null), // disc = 1/1
// (MetadataProperty.DiscTotal, typeof(string), "album",null), // disc = 1/1
(MetadataProperty.EncodedBy, typeof(string), "encoded_by",null),
// (MetadataProperty.EncoderSettings, typeof(string), "album",null),
Expand Down Expand Up @@ -273,6 +276,13 @@ private static void ParseMetadataProperties(Dictionary<string, string> propertie
orderedKeys.Add(ffmetakey);
foreach (var propertyKey in orderedKeys.Where(properties.ContainsKey))
{

/*
if (propertyKey == "disk")
{
}
*/
metadata.SetMetadataPropertyValue(property, properties[propertyKey], type);
}
}
Expand Down
20 changes: 4 additions & 16 deletions tone/doc/release/release-notes-v0.1.6.md
Original file line number Diff line number Diff line change
@@ -1,29 +1,17 @@
# Release Notes

## todo
- Finish Id-Tagger + docs (for tagging via remotes with id, e.g. musicbrainz, ASIN, etc.)
- AudibleIdTagger
-
- Try to use "year only" on date properties: https://github.com/sandreas/tone/issues/45
- Fix missing metadata specs #46: https://github.com/sandreas/DotnetLibAudioMetadata/blob/0feeda2978cff3d84abd0644c1ae3ccf185d63df/Sandreas.AudioMetadata/AudioMetadata/MetadataTrack.cs#L263

# later
- More ffmetadata support (https://github.com/sandreas/tone/issues/39)


## Fixed

- tone falsely reported as malware (#41)
- movement tag is not removed (#44)



## Changed
- Upgrated `atldotnet` library
- Upgrated `Jint` library (https://github.com/sandreas/tone/issues/40)
- Upgrated `atldotnet` library (#58, #59)
- Upgrated `Jint` library (#40)
- Improved `ffmetadata` support (#39)

## Added

- Prepared code making it possible to use `--id` for simpler id based taggers (e.g. musicbrainz id)
- `--export` option for `dump` command - allows you to export metadata in file (can be used together with `--format`, defaults to `json`)


Expand Down

0 comments on commit e157c93

Please sign in to comment.