-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temporary fix for cucumber tests #4316
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4316 +/- ##
===========================================
+ Coverage 85.51% 87.52% +2.00%
===========================================
Files 1375 1375
Lines 29680 29680
===========================================
+ Hits 25381 25977 +596
+ Misses 4299 3703 -596 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the WIP flag, well done finding the responsible feature and the flag to work around it.
I don't know if we need the other flags or not but they look sensible. Are there other browsers we can turn to if Chrome does remove this mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
Closes #
Changes proposed in this pull request
headless=old
to get the tests pass.SeleniumHQ/selenium#14438
"Driving Chrome 128 through Selenium on a machine without Chrome installed fails connecting to Chrome, be it headless or not, unless asking for headless=old. The disable-search-engine-choice-screen argument does not change anything about this.
It works only if Chrome is directly installed on the machine when not setting --headless=old."
https://developer.chrome.com/docs/chromium/new-headless
Note that it says the following in that page but it seems to be still supported:
"We intend to remove the old Headless from the Chrome binary and stop supporting this mode"
SeleniumHQ/selenium#14453
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version