Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (277c65c) |
|---|---|---|
| Internal (raw) | 2.3 KB | +63 B, +2.8% |
| Internal (gzip) | 872 B | +34 B, +4.1% |
| Bundled (raw) | 11.16 MB | +42 B, +0.0% |
| Bundled (gzip) | 2.10 MB | -178 B, -0.0% |
| Import time | 320ms | -541ms, -62.8% |
bin:sanity
| Metric | Value | vs main (277c65c) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.27s | +28ms, +1.2% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (277c65c6)
| Metric | Value | vs main (277c65c) |
|---|---|---|
| Internal (raw) | 108.1 KB | - |
| Internal (gzip) | 27.0 KB | - |
| Bundled (raw) | 21.72 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 757ms | -24ms, -3.0% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (277c65c6)
| Metric | Value | vs main (277c65c) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
Contributor
Coverage Delta
Comparing 34 changed files against main @ Overall Coverage
|
filmaj
force-pushed
the
barreled
branch
5 times, most recently
from
91bf3fc to
dcc8014
Compare
add mock modules for cli-core to cli-test test(chore): use import for vi.mock, some more import hygiene test(chore): enable reporting import times during test runs test(chore): do very granular exports, use them wherever possible test(chore): the great unbarreling continues test(chore): mock out workbench cli build module in buildapp test test(chore): fix up test mocks for buildStudio test test(chore): fix up buildstudio tests test(chore): fix up comparedep tests test(chore): fix up buildapp tests test(chore): fix up workbench unit tests test(chore): move module URL tests to the right place test(chore): further chopping up cli-core and cli-build exports test(chore): export buildStaticFiles test(chore): fix up extract core tests test(chore): fix up build studio tests, export some more stuff from cli-build test(chore): fix up build studio tests test(chore): fix up build app tests test(chore): reorganizing cli-core exports, cli tweaks too test(chore): reorganizing cli-core exports test(chore): tweaking cli-core exports, workbench-cli to use the fine-grained exports of cli-core test(chore): remove workbench dev tests in the wrong module test(chore): fix up remaining workbench tests test(chore): we dont need cli buildstudio tests anymore really test(chore): unbarrelinngggggg test(chore): new export for cli-core test(chore): cli-core UNBARRELEDDDD test(chore): add mock output creation helper function to cli/test export. test fixups test(chore): post-barreling test/mock fixup test(chore): post-barreling test/mock fixup, expanding cli-test exports with paths util test(chore): post-barreling test/mock fixup, different way of wedging in mock sanity command test(chore): speed up imports in test test(chore): dont do coverage in integration tests, dont use snapshots in unit test(chore): dataset export tests refactor(chore): move debug to _exports in cli-core refactor(chore): big cli-core export reorg refactor(chore): big cli-core export reorg consumption side refactor(test): proving out mock modules provided by cli-test refactor(test): more mocks to cli-test, more tests converted refactor(test): more tests converted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP
What to review
Testing