Skip to content

Commit

Permalink
fix(sanity): prevent intendedPublishAt being set to undefined whe…
Browse files Browse the repository at this point in the history
…n it should instead be omitted
  • Loading branch information
juice49 committed Feb 19, 2025
1 parent 4072aa6 commit 8ba1942
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,15 @@ export function ReleaseTypePicker(props: {release: NotArchivedRelease}): React.J
if (open && !dialog) {
const newRelease = {
...release,
metadata: {...release.metadata, intendedPublishAt: updatedDate, releaseType},
metadata: {
...release.metadata,
releaseType,
...(typeof updatedDate === 'undefined'
? {}
: {
intendedPublishAt: updatedDate,
}),
},
}

if (!isEqual(newRelease, release)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ describe('ReleaseTypePicker', () => {
...activeASAPRelease,
metadata: expect.objectContaining({
...activeASAPRelease.metadata,
intendedPublishAt: undefined,
releaseType: 'undecided',
}),
})
Expand Down

0 comments on commit 8ba1942

Please sign in to comment.