You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch adds release errors to the data model and updates the UI to reflect the presence of a release error. Presence of an error is only taken into account for releases that are in an active state.
This branch does not include a way to deal with a release error. We'll likely want to allow folks to manually publish release, allowing the remaining unpublished documents to be published. Decided to exclude this work for now, because a lot of the publication logic is encoded into the publish button itself, making it tricky to extract into a different context. This is expected to be a very narrow edge case.
What to review
When there are errors present
The releases tool icon is given a small error indicator
The releases list view will display an error indicator in the affected row
The release detail view will show an error indicator at the start
The release detail view will show an error detail UI
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
44ms
49ms
60ms
455ms
840ms
11.3s
article (body)
16ms
18ms
23ms
217ms
309ms
5.4s
article (string inside object)
41ms
44ms
46ms
151ms
237ms
7.5s
article (string inside array)
47ms
50ms
54ms
245ms
547ms
7.7s
recipe (name)
20ms
21ms
23ms
40ms
0ms
7.6s
recipe (description)
18ms
19ms
21ms
37ms
0ms
4.5s
recipe (instructions)
5ms
7ms
7ms
32ms
0ms
3.1s
synthetic (title)
56ms
58ms
66ms
510ms
1157ms
15.4s
synthetic (string inside object)
54ms
55ms
59ms
440ms
1052ms
8.8s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
43ms
64ms
77ms
477ms
943ms
11.6s
article (body)
15ms
16ms
21ms
65ms
205ms
5.1s
article (string inside object)
39ms
41ms
46ms
262ms
282ms
6.8s
article (string inside array)
45ms
47ms
51ms
175ms
456ms
7.4s
recipe (name)
21ms
21ms
24ms
36ms
0ms
6.9s
recipe (description)
19ms
19ms
21ms
29ms
0ms
4.6s
recipe (instructions)
5ms
7ms
8ms
24ms
0ms
3.1s
synthetic (title)
53ms
56ms
82ms
470ms
1104ms
13.3s
synthetic (string inside object)
51ms
54ms
57ms
117ms
750ms
8.3s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch adds release errors to the data model and updates the UI to reflect the presence of a release error. Presence of an error is only taken into account for releases that are in an active state.
This branch does not include a way to deal with a release error. We'll likely want to allow folks to manually publish release, allowing the remaining unpublished documents to be published. Decided to exclude this work for now, because a lot of the publication logic is encoded into the publish button itself, making it tricky to extract into a different context. This is expected to be a very narrow edge case.
What to review
When there are errors present
The releases tool icon is given a small error indicator
The releases list view will display an error indicator in the affected row
The release detail view will show an error indicator at the start
The release detail view will show an error detail UI
Testing
Notes for release
Adds release error details to UI.