feat(sanity): add Core UI bridge script #8523

juice49 · 2025-02-06T11:50:14Z

Description

This branch adds the bridge script to the HTML output when building Studio with the standard tooling.

What to review

Addition of the bridge script when running dev server and building HTML for production.

Testing

Ensure the bridge script is loaded when running the dev server and in a production build.

vercel · 2025-02-06T11:50:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 11, 2025 11:17am
performance-studio	🛑 Canceled (Inspect)			Feb 11, 2025 11:17am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 11, 2025 11:17am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 11, 2025 11:17am
test-next-studio	⬜️ Ignored (Inspect)			Feb 11, 2025 11:17am

github-actions · 2025-02-06T14:53:08Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.43%	53738 / 126640
🔵	Statements	42.43%	53738 / 126640
🔵	Functions	47.93%	2769 / 5777
🔵	Branches	78.76%	10285 / 13058

File Coverage

No changed files found.

Generated in workflow #30142 for commit 161cd7f by the Vitest Coverage Report Action

github-actions · 2025-02-06T14:53:45Z

No changes to documentation

github-actions · 2025-02-06T14:59:43Z

Component Testing Report Updated Feb 11, 2025 11:26 AM (UTC)

❌ Failed Tests (3) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 9s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	1m 57s	4	0	2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	53s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	15s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 7s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 34s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	2m 6s	21	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	❌ Failed (Inspect)	2m 26s	20	0	1
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

github-actions · 2025-02-06T15:01:27Z

⚡️ Editor Performance Report

Updated Tue, 11 Feb 2025 11:23:02 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	27.0 efps (37ms)	28.6 efps (35ms)	-2ms (-5.4%)	✅
article (body)	69.9 efps (14ms)	81.3 efps (12ms)	-2ms (-/-%)	✅
article (string inside object)	29.0 efps (35ms)	27.8 efps (36ms)	+2ms (+4.3%)	✅
article (string inside array)	25.6 efps (39ms)	24.4 efps (41ms)	+2ms (+5.1%)	✅
recipe (name)	50.0 efps (20ms)	52.6 efps (19ms)	-1ms (-5.0%)	✅
recipe (description)	58.8 efps (17ms)	58.8 efps (17ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	20.0 efps (50ms)	20.8 efps (48ms)	-2ms (-4.0%)	✅
synthetic (string inside object)	20.0 efps (50ms)	19.6 efps (51ms)	+1ms (+2.0%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	37ms	41ms	59ms	154ms	161ms	10.1s
article (body)	14ms	16ms	18ms	47ms	67ms	5.3s
article (string inside object)	35ms	36ms	41ms	196ms	222ms	6.3s
article (string inside array)	39ms	42ms	46ms	148ms	122ms	6.7s
recipe (name)	20ms	23ms	25ms	42ms	0ms	7.3s
recipe (description)	17ms	18ms	22ms	35ms	0ms	4.5s
recipe (instructions)	5ms	7ms	9ms	23ms	0ms	3.1s
synthetic (title)	50ms	54ms	59ms	370ms	817ms	13.2s
synthetic (string inside object)	50ms	51ms	56ms	109ms	848ms	8.3s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	35ms	40ms	44ms	407ms	257ms	11.5s
article (body)	12ms	14ms	16ms	168ms	173ms	4.9s
article (string inside object)	36ms	38ms	40ms	145ms	113ms	6.6s
article (string inside array)	41ms	42ms	46ms	142ms	135ms	6.8s
recipe (name)	19ms	21ms	22ms	39ms	0ms	6.5s
recipe (description)	17ms	19ms	21ms	53ms	0ms	4.5s
recipe (instructions)	5ms	6ms	8ms	18ms	0ms	3.1s
synthetic (title)	48ms	51ms	57ms	400ms	911ms	13.6s
synthetic (string inside object)	51ms	53ms	56ms	350ms	903ms	8.2s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

juice49 · 2025-02-11T11:47:24Z

I've tested this using the dev server and the production build, and the bridge script loads correctly in both scenarios. This looks good to me.

juice49 force-pushed the feat/core branch from 190795c to 2d8c1ba Compare February 6, 2025 14:48

vercel bot deployed to Preview – page-building-studio February 6, 2025 14:55 View deployment

vercel bot deployed to Preview – performance-studio February 6, 2025 14:55 View deployment

vercel bot deployed to Preview – test-studio February 6, 2025 14:56 View deployment

vercel bot deployed to Preview – performance-studio February 10, 2025 13:33 View deployment

vercel bot deployed to Preview – page-building-studio February 10, 2025 13:33 View deployment

vercel bot deployed to Preview – test-studio February 10, 2025 13:34 View deployment

juice49 changed the title ~~Feat/core~~ feat(sanity): add Core UI bridge script Feb 11, 2025

joshuaellis added 2 commits February 11, 2025 11:09

feat: add bridge script with useInsertionEffect in Studio component

295a490

chore: refactor to decorate index html

04a89e9

juice49 force-pushed the feat/core branch from dbf1809 to 1597b90 Compare February 11, 2025 11:09

fix: decorate production index.html with bridge script

161cd7f

juice49 force-pushed the feat/core branch from 1597b90 to 161cd7f Compare February 11, 2025 11:10

vercel bot deployed to Preview – page-building-studio February 11, 2025 11:15 View deployment

vercel bot deployed to Preview – performance-studio February 11, 2025 11:16 View deployment

vercel bot deployed to Preview – test-studio February 11, 2025 11:17 View deployment

juice49 marked this pull request as ready for review February 11, 2025 11:34

juice49 requested a review from a team as a code owner February 11, 2025 11:34

juice49 requested review from bjoerge and removed request for a team February 11, 2025 11:34

juice49 enabled auto-merge February 11, 2025 11:47

EoinFalconer approved these changes Feb 11, 2025

View reviewed changes

juice49 added this pull request to the merge queue Feb 11, 2025

Merged via the queue into next with commit 8e1ed89 Feb 11, 2025
65 checks passed

juice49 deleted the feat/core branch February 11, 2025 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sanity): add Core UI bridge script #8523

feat(sanity): add Core UI bridge script #8523

juice49 commented Feb 6, 2025 •

edited

Loading

vercel bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

juice49 commented Feb 11, 2025

feat(sanity): add Core UI bridge script #8523

feat(sanity): add Core UI bridge script #8523

Conversation

juice49 commented Feb 6, 2025 • edited Loading

Description

What to review

Testing

vercel bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

Coverage Report

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025 • edited Loading

github-actions bot commented Feb 6, 2025 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

juice49 commented Feb 11, 2025

juice49 commented Feb 6, 2025 •

edited

Loading

vercel bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading

github-actions bot commented Feb 6, 2025 •

edited

Loading