fix(sanity): use raw as default perspective #8586
Merged
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
bjoerge
commented
Feb 11, 2025
| @@ -54,7 +54,7 @@ function listen(id: string, fields: string[], store: DocumentStore) { | |||
| } | |||
| const params = {id, draftId: getDraftId(id)} | |||
| return store.listenQuery(query, params, { | |||
| perspective: 'previewDrafts', | |||
| perspective: 'drafts', | |||
There was a problem hiding this comment.
not strictly related, but took the liberty of renaming this when I came across it.
bjoerge
commented
Feb 11, 2025
| ) | ||
| return source.getClient({apiVersion: '2021-06-07'}) | ||
| return source.getClient({apiVersion: 'v2025-02-07'}) |
There was a problem hiding this comment.
We soon want to bump the version used by all internal code, so I think this change is sensible, esp. considering we've had the above warning throughout the lifetime of v3
There was a problem hiding this comment.
This makes sense to me, I wonder if we would want to use here the DEFAULT_STUDIO_CLIENT_OPTIONS instead of this
There was a problem hiding this comment.
Yes, will make a separate PR for it – would prefer a change like that to be subjected to a bit more testing :)
|
No changes to documentation |
bjoerge
commented
Feb 11, 2025
| @@ -161,6 +161,7 @@ export function _createAuthStore({ | |||
| useCdn: false, | |||
| ...(token && {token}), | |||
| withCredentials: true, | |||
| perspective: 'raw', | |||
There was a problem hiding this comment.
the client created here is the basis of the client used throughout the Studio, and its config is inherited by client instances returned by useClient() etc.
⚡️ Editor Performance ReportUpdated Tue, 11 Feb 2025 10:06:16 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
|
Component Testing Report Updated Feb 11, 2025 10:31 AM (UTC) ❌ Failed Tests (3) -- expand for details
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
bjoerge
requested review from
RitaDias and
pedrobonamin
and removed request for
a team
pedrobonamin
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(meta: wrong ticket id, should've been sapp-2049)
Description
This explicitly uses
rawas perspective unless overridden (e.g. by perspective stack)This change should be safe, given that raw is currently the default on existing API versions.
What to review
Does the change make sense? As of this PR, Studio should longer do
/queryrequests without a perspective param.Testing
Everything should work as before
Notes for release
n/a - not user facing