Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(playwright-ct): bump number of retries for playwright ct tests #8589

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Feb 11, 2025

Description

Bumping number of retries component tests on CI from 2 to 6 to mitigate flake.

What to review

Does it make sense?

Testing

Yep :)

Notes for release

n/a

@bjoerge bjoerge requested a review from a team as a code owner February 11, 2025 11:13
@bjoerge bjoerge requested review from jordanl17 and removed request for a team February 11, 2025 11:13
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 11:14am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 11:14am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 11:14am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 11, 2025 11:14am
test-next-studio ⬜️ Ignored (Inspect) Feb 11, 2025 11:14am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.43% 53738 / 126640
🔵 Statements 42.43% 53738 / 126640
🔵 Functions 47.93% 2769 / 5777
🔵 Branches 78.74% 10273 / 13046
File CoverageNo changed files found.
Generated in workflow #30144 for commit d2bf7c3 by the Vitest Coverage Report Action

Copy link
Contributor

Component Testing Report Updated Feb 11, 2025 11:25 AM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 57s 4 0 2
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 38s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 7s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 11 Feb 2025 11:27:54 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 27.0 efps (37ms) 27.8 efps (36ms) -1ms (-2.7%)
article (body) 72.5 efps (14ms) 77.5 efps (13ms) -1ms (-/-%)
article (string inside object) 27.0 efps (37ms) 27.8 efps (36ms) -1ms (-2.7%)
article (string inside array) 24.4 efps (41ms) 23.8 efps (42ms) +1ms (+2.4%)
recipe (name) 50.0 efps (20ms) 50.0 efps (20ms) +0ms (-/-%)
recipe (description) 55.6 efps (18ms) 58.8 efps (17ms) -1ms (-5.6%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.0 efps (50ms) 20.2 efps (50ms) -1ms (-1.0%)
synthetic (string inside object) 19.6 efps (51ms) 20.0 efps (50ms) -1ms (-2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 41ms 49ms 428ms 616ms 12.2s
article (body) 14ms 17ms 20ms 65ms 57ms 5.0s
article (string inside object) 37ms 40ms 43ms 230ms 331ms 7.1s
article (string inside array) 41ms 44ms 51ms 69ms 264ms 6.9s
recipe (name) 20ms 21ms 25ms 48ms 0ms 7.5s
recipe (description) 18ms 19ms 21ms 30ms 0ms 4.5s
recipe (instructions) 5ms 7ms 9ms 13ms 0ms 3.0s
synthetic (title) 50ms 52ms 56ms 217ms 593ms 12.1s
synthetic (string inside object) 51ms 57ms 76ms 521ms 1347ms 8.8s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 36ms 39ms 46ms 292ms 140ms 10.8s
article (body) 13ms 16ms 21ms 123ms 186ms 5.0s
article (string inside object) 36ms 39ms 42ms 126ms 153ms 6.7s
article (string inside array) 42ms 45ms 48ms 167ms 119ms 7.0s
recipe (name) 20ms 21ms 25ms 48ms 0ms 8.2s
recipe (description) 17ms 18ms 22ms 35ms 0ms 4.4s
recipe (instructions) 5ms 6ms 8ms 9ms 0ms 3.0s
synthetic (title) 50ms 53ms 63ms 407ms 860ms 13.3s
synthetic (string inside object) 50ms 53ms 57ms 245ms 701ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge added this pull request to the merge queue Feb 11, 2025
Merged via the queue into next with commit a9a1b95 Feb 11, 2025
62 checks passed
@bjoerge bjoerge deleted the bump-playwright-ct-retries branch February 11, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants