Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): correct the default port for Astro app #8699

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

kenjonespizza
Copy link

Description

Update the default port assigned to Astro when setting CORS origin during the --template CLI initiation.

What to review

You could review that 4321 is the correct port. Astro Docs

To replicate this, you can try installing the Astro template with npm create sanity@latest -- --template sanity-io/sanity-template-astro-clean and them viewing the manage console to see that http://localhost:3000 was added as a CORS origin.

Testing

Im not totally sure.

Notes for release

@kenjonespizza kenjonespizza requested a review from a team as a code owner February 18, 2025 22:53
@kenjonespizza kenjonespizza requested review from ryanbonial and removed request for a team February 18, 2025 22:53
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:53pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:53pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:53pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 18, 2025 10:53pm
test-next-studio ⬜️ Ignored (Inspect) Feb 18, 2025 10:53pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.94% 54791 / 127596
🔵 Statements 42.94% 54791 / 127596
🔵 Functions 48.09% 2788 / 5797
🔵 Branches 79.46% 10616 / 13360
File CoverageNo changed files found.
Generated in workflow #30679 for commit 549bedd by the Vitest Coverage Report Action

Copy link
Contributor

Component Testing Report Updated Feb 18, 2025 11:05 PM (UTC)

❌ Failed Tests (4) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 18s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 45s 3 0 3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 59s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 17s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 1m 57s 14 0 1
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 19s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 15s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 2m 0s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 18 Feb 2025 23:06:10 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 29.0 efps (35ms) 25.6 efps (39ms) +5ms (+13.0%)
article (body) 72.5 efps (14ms) 72.5 efps (14ms) +0ms (-/-%)
article (string inside object) 26.0 efps (39ms) 25.6 efps (39ms) +1ms (+1.3%)
article (string inside array) 25.0 efps (40ms) 22.7 efps (44ms) +4ms (+10.0%)
recipe (name) 45.5 efps (22ms) 51.3 efps (20ms) -3ms (-11.4%)
recipe (description) 47.6 efps (21ms) 55.6 efps (18ms) -3ms (-14.3%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 18.7 efps (54ms) 20.4 efps (49ms) -5ms (-8.4%)
synthetic (string inside object) 20.4 efps (49ms) 20.4 efps (49ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 35ms 36ms 39ms 135ms 9ms 9.1s
article (body) 14ms 18ms 21ms 92ms 444ms 5.5s
article (string inside object) 39ms 41ms 43ms 121ms 115ms 6.6s
article (string inside array) 40ms 41ms 45ms 65ms 117ms 6.5s
recipe (name) 22ms 23ms 25ms 35ms 0ms 7.1s
recipe (description) 21ms 23ms 27ms 47ms 0ms 5.1s
recipe (instructions) 6ms 7ms 8ms 17ms 0ms 3.3s
synthetic (title) 54ms 57ms 68ms 204ms 964ms 13.0s
synthetic (string inside object) 49ms 53ms 55ms 247ms 620ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 43ms 61ms 395ms 184ms 10.6s
article (body) 14ms 16ms 33ms 120ms 205ms 5.5s
article (string inside object) 39ms 42ms 48ms 363ms 490ms 7.8s
article (string inside array) 44ms 46ms 50ms 83ms 380ms 7.5s
recipe (name) 20ms 22ms 25ms 35ms 2ms 8.2s
recipe (description) 18ms 19ms 20ms 38ms 0ms 4.5s
recipe (instructions) 5ms 6ms 7ms 18ms 0ms 3.1s
synthetic (title) 49ms 55ms 65ms 428ms 1229ms 13.0s
synthetic (string inside object) 49ms 51ms 61ms 375ms 997ms 8.1s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant