You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch adds a polyfill that uses various techniques to implement task scheduling when necessary.
I had some difficulty getting the polyfill to work correctly in node, which is where our unit tests run at the moment (a good reason to adopt Vitest Browser Mode, in my opinion!). I created a small postTask helper function that executes the provided callback immediately if neither the Prioritized Task Scheduling API or its polyfill is available. The only impact of this is that it allows our tests to run in node.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
43ms
48ms
50ms
158ms
192ms
11.0s
article (body)
12ms
15ms
17ms
28ms
47ms
4.9s
article (string inside object)
38ms
39ms
41ms
169ms
12ms
6.7s
article (string inside array)
45ms
48ms
50ms
52ms
145ms
7.0s
recipe (name)
23ms
25ms
27ms
46ms
0ms
7.3s
recipe (description)
20ms
21ms
22ms
30ms
0ms
4.7s
recipe (instructions)
5ms
7ms
8ms
12ms
0ms
3.1s
synthetic (title)
60ms
66ms
77ms
378ms
2334ms
15.5s
synthetic (string inside object)
50ms
52ms
55ms
205ms
768ms
8.1s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
43ms
69ms
76ms
179ms
624ms
11.6s
article (body)
15ms
16ms
18ms
58ms
56ms
5.5s
article (string inside object)
40ms
42ms
48ms
141ms
298ms
6.9s
article (string inside array)
45ms
46ms
47ms
59ms
247ms
7.1s
recipe (name)
23ms
24ms
30ms
50ms
9ms
7.7s
recipe (description)
21ms
22ms
24ms
29ms
0ms
5.2s
recipe (instructions)
5ms
6ms
8ms
17ms
0ms
3.2s
synthetic (title)
51ms
56ms
64ms
354ms
990ms
13.2s
synthetic (string inside object)
51ms
52ms
56ms
217ms
659ms
8.0s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This branch adds a polyfill that uses various techniques to implement task scheduling when necessary.I had some difficulty getting the polyfill to work correctly in node, which is where our unit tests run at the moment (a good reason to adopt Vitest Browser Mode, in my opinion!). I created a smallpostTask
helper function that executes the provided callback immediately if neither the Prioritized Task Scheduling API or its polyfill is available. The only impact of this is that it allows our tests to run in node.What to review
Testing
Notes for release