Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): add Scheduler polyfill #9024

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Mar 24, 2025

Description

This branch adds a polyfill that uses various techniques to implement task scheduling when necessary.

I had some difficulty getting the polyfill to work correctly in node, which is where our unit tests run at the moment (a good reason to adopt Vitest Browser Mode, in my opinion!). I created a small postTask helper function that executes the provided callback immediately if neither the Prioritized Task Scheduling API or its polyfill is available. The only impact of this is that it allows our tests to run in node.

What to review

Testing

Notes for release

Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 11:17am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 11:17am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 11:17am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 24, 2025 11:17am
test-next-studio ⬜️ Ignored (Inspect) Mar 24, 2025 11:17am

@juice49 juice49 force-pushed the feat/scheduler-polyfill branch from 7795b63 to 3de2aca Compare March 24, 2025 11:05
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 71.7 kB google-wombot

View full report↗︎

Copy link
Contributor

No changes to documentation

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 24 Mar 2025 11:33:26 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.3 efps (43ms) 23.3 efps (43ms) +0ms (-/-%)
article (body) 81.3 efps (12ms) 67.8 efps (15ms) +2ms (-/-%)
article (string inside object) 26.3 efps (38ms) 25.0 efps (40ms) +2ms (+5.3%)
article (string inside array) 22.2 efps (45ms) 22.2 efps (45ms) +0ms (-/-%)
recipe (name) 43.5 efps (23ms) 43.5 efps (23ms) +0ms (-/-%)
recipe (description) 50.0 efps (20ms) 47.6 efps (21ms) +1ms (+5.0%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 16.7 efps (60ms) 19.6 efps (51ms) -9ms (-15.0%)
synthetic (string inside object) 20.0 efps (50ms) 19.6 efps (51ms) +1ms (+2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 48ms 50ms 158ms 192ms 11.0s
article (body) 12ms 15ms 17ms 28ms 47ms 4.9s
article (string inside object) 38ms 39ms 41ms 169ms 12ms 6.7s
article (string inside array) 45ms 48ms 50ms 52ms 145ms 7.0s
recipe (name) 23ms 25ms 27ms 46ms 0ms 7.3s
recipe (description) 20ms 21ms 22ms 30ms 0ms 4.7s
recipe (instructions) 5ms 7ms 8ms 12ms 0ms 3.1s
synthetic (title) 60ms 66ms 77ms 378ms 2334ms 15.5s
synthetic (string inside object) 50ms 52ms 55ms 205ms 768ms 8.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 69ms 76ms 179ms 624ms 11.6s
article (body) 15ms 16ms 18ms 58ms 56ms 5.5s
article (string inside object) 40ms 42ms 48ms 141ms 298ms 6.9s
article (string inside array) 45ms 46ms 47ms 59ms 247ms 7.1s
recipe (name) 23ms 24ms 30ms 50ms 9ms 7.7s
recipe (description) 21ms 22ms 24ms 29ms 0ms 5.2s
recipe (instructions) 5ms 6ms 8ms 17ms 0ms 3.2s
synthetic (title) 51ms 56ms 64ms 354ms 990ms 13.2s
synthetic (string inside object) 51ms 52ms 56ms 217ms 659ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant