-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove legacy exports #9036
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Coverage Report
File CoverageNo changed files found. |
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
64f497b
to
16451ba
Compare
16451ba
to
bd7a1dc
Compare
bd7a1dc
to
08cf005
Compare
08cf005
to
1d53406
Compare
⚡️ Editor Performance ReportUpdated Tue, 01 Apr 2025 12:58:17 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Description
We've stopped using
legacyExports
in@sanity/ui
a while back, and it's no longer a feature in@sanity/pkg-utils@7
. It's time to remove it fromsanity
and related monorepo packages as well.This reduces the way we ship code to npm from dual ESM + CJS + legacy ESM to just dual ESM + CJS.
Building legacy exports accounts for 33% of the total build time by
@sanity/pkg-utils
, which impacts how long it takes for the monorepo to runpnpm build
, and every CLI task that needspnpm build
, which is all of the E2E test suites, as well as the eFPS suite.All to support legacy Node.js runtimes, and test runners like older Jest versions, that doesn't support the
package.json
exports
field.What to review
It builds and makes sense.
Testing
If it builds it works.
Notes for release
Legacy ESM is no longer shipped to npm. Ensure you're on Node.js v18 or later, and if using Jest make sure you're on v28 or later.