Skip to content

[Snyk] Fix for 3 vulnerabilities #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sankalpdomore wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 3 vulnerabilities #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ git+https://github.com/zapier/django-rest-hooks.git@v1.6.0
# via -r requirements.in
django-statsd==2.5.2
# via -r requirements.in
django==3.1.8
django==4.2.27

@cursor cursor Bot Dec 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Django 4.2 requires higher asgiref version than pinned

The upgrade to django==4.2.27 creates a dependency conflict with asgiref==3.3.1 which remains pinned at line 13. Django 4.2.x requires asgiref>=3.6.0, but the current version is 3.3.1. This incompatibility will cause pip to fail during dependency resolution or result in runtime errors. The PR's own warning explicitly notes this conflict.

Additional Locations (1)

Fix in Cursor Fix in Web

@cursor cursor Bot Dec 6, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Source requirements.in not updated, fix will be reverted

The requirements.txt was updated but requirements.in still pins Django==3.1.8 (line 13) and asgiref==3.3.1 (line 5). Since requirements.txt is autogenerated by pip-compile requirements.in, running this command will silently revert the security fix back to the vulnerable versions. The source file needs to be updated for this fix to persist.

Fix in Cursor Fix in Web

# via
# -r requirements.in
# django-axes
Expand Down Expand Up @@ -205,7 +205,7 @@ social-auth-core==4.0.2
# via
# -r requirements.in
# social-auth-app-django
sqlparse==0.3.0
sqlparse==0.5.4
# via django
statshog==1.0.6
# via -r requirements.in
Expand Down